Skip to content

feat(project): 画风改为可选择的受控档位 - #603

Merged
huyanxius merged 5 commits into
1024XEngineer:mainfrom
johnnyzhang-eng:feat/game-style-enum-ui
Aug 25, 2026
Merged

huyanxius merged 5 commits into
1024XEngineer:mainfrom
johnnyzhang-eng:feat/game-style-enum-ui

Conversation

@johnnyzhang-eng

Copy link
Copy Markdown
Contributor

叠在 #600 上,先合 #600。本 PR 的自有改动只有最上面那个 commit(feat(project): 画风改为可选择的受控档位)。

#600 把 game_style 收敛成枚举,但它单独上线不改变任何生产行为 —— 新老项目这一列都是 NULL,没有入口会送出枚举值,stylize 仍恒为 none。这条 PR 是让它真的生效的那一半。

改动

  • 创建页的自由文本框换成档位选择,Quick Start 入口与画布左下角的约束条也加上同一份,每档配一句说明(用户选画风时看不到管线,差别得讲出来)。
  • 画布上改画风只影响后续生成,本页记住新值,不重拉整个 session。
  • ProjectOut.game_style 归一成枚举。不归一会有一处两边不一致:存量项目存的是「像素风格」,后端判它是像素,而前端不做子串匹配(也不该做)会显示成「不指定」。
  • Quick Start 的画风经宿主注入,quick-start-agent 仍不认识业务对象,只做透传。

不包含

验证

  • 前端 format:check / lint / typecheck / test(72 文件 1037 用例)/ build:全过。
  • 后端 ruff / pytest(1374 passed, 14 skipped)/ export_openapi 无漂移:全过。

Closes #602

@vercel

vercel Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 25, 2026 9:48am

@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.43750% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
frontend/src/pages/workflow-editor/index.tsx 33.33% 7 Missing and 1 partial ⚠️
frontend/src/pages/quick-start/index.tsx 71.42% 3 Missing and 3 partials ⚠️
frontend/src/entities/project/index.ts 83.33% 1 Missing ⚠️
...ntend/src/features/quick-start-agent/production.ts 50.00% 0 Missing and 1 partial ⚠️
...src/pages/workflow-editor/workflow-editor-view.tsx 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   89.58%   89.52%   -0.07%     
==========================================
  Files         260      260              
  Lines       17847    17895      +48     
  Branches     2547     2555       +8     
==========================================
+ Hits        15988    16020      +32     
- Misses       1185     1197      +12     
- Partials      674      678       +4     
Flag Coverage Δ
backend 92.86% <100.00%> (+<0.01%) ⬆️
frontend 85.22% <67.92%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...end/packages/app/src/windup_app/web/api/project.py 93.18% <100.00%> (+0.55%) ⬆️
frontend/src/features/quick-start-agent/react.ts 78.64% <100.00%> (ø)
frontend/src/features/quick-start-agent/runtime.ts 74.15% <100.00%> (+0.14%) ⬆️
...end/src/features/workflow-controller/controller.ts 86.03% <100.00%> (ø)
frontend/src/pages/project-create/index.tsx 95.89% <100.00%> (-0.06%) ⬇️
frontend/src/pages/projects/index.tsx 85.71% <ø> (-0.13%) ⬇️
frontend/src/pages/quick-start/service.ts 81.15% <100.00%> (ø)
frontend/src/entities/project/index.ts 80.76% <83.33%> (+0.33%) ⬆️
...ntend/src/features/quick-start-agent/production.ts 94.33% <50.00%> (-1.82%) ⬇️
...src/pages/workflow-editor/workflow-editor-view.tsx 87.50% <50.00%> (-5.84%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review conclusion

画风枚举本身、后端生成约束映射和三个入口的主链路整体一致;但显式清空、画布保存时序、以及 Quick Start 草稿恢复这三个状态转换会让界面选择与后端实际生成画风不一致。已检查固定提交范围并运行 git diff --check;当前环境未安装 uv 或前端依赖,因此未重复执行测试套件。

View job run

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

Deployment failed for project windup with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/huyan-s-projects1?upgradeToPro=build-rate-limit

@johnnyzhang-eng
johnnyzhang-eng force-pushed the feat/game-style-enum-ui branch from f61f7f6 to 804eddd Compare August 24, 2026 09:09
@johnnyzhang-eng

Copy link
Copy Markdown
Contributor Author

那个红叉是 Vercel 的部署限流(Deployment rate limited — retry in 24 hours),不是代码问题:今天为了修 fennoai 提的几条 P1 反复推了几次,把当天的预览部署配额用完了。lint-and-test 与 Frontend checks 都是绿的,main 也没有 required_status_checks 规则,所以它不影响合并。

xyh202131
xyh202131 previously approved these changes Aug 25, 2026
@johnnyzhang-eng

Copy link
Copy Markdown
Contributor Author

已 rebase 到最新 main,冲突只有 test_generation_orchestration.py 一处,两侧各自追加的用例互不重叠,都保留了。后端 ruff / lint-imports / pytest 与前端 lint / test 都在这次改动之后重跑过。force-push 把上一次的 approve 冲掉了,麻烦重看一下。

xyh202131
xyh202131 previously approved these changes Aug 25, 2026
@huyanxius

Copy link
Copy Markdown
Collaborator

处理一下冲突?

@huyanxius huyanxius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

冲突已按最新 main 语义解决;相关前端测试、格式、lint、typecheck 与构建均通过。

@huyanxius
huyanxius merged commit 9a52e0c into 1024XEngineer:main Aug 25, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview — cc25d5e7 Deployed Aug 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(project): 画风档位接到用户能选的三个入口

3 participants