Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ 此 PR 已关联 issue,之前的提醒已自动标记为已解决。 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
/review |
There was a problem hiding this comment.
Reviewed the complete fixed diff, including the direction contract, workflow controller, backend validation, and asset publication paths. The new controller correctly schedules all required directions, but the profile migration leaves existing publication/quick-start consumers on the legacy sourceDirections list, so multi-direction results are not preserved end to end. git diff --check passes; local test runners were unavailable because the frontend vitest binary is non-executable and backend pytest is not installed.
0f6ae51 to
2aa6d29
Compare
There was a problem hiding this comment.
The controller/backend now create real generation tasks for all four/eight directions, but the editor/export path still consumes sourceDirections, which remains the legacy 3/5-direction subset. As a result, newly generated west/diagonal results are not rendered or selected in Workflow Editor and are not required/published by the export path, so a run can appear complete while silently dropping those assets. The profile needs one consistent set of required real directions across generation, UI, and publication (or all consumers must be migrated to the new field).
Verification was limited to static call-site tracing because the checkout has no executable vitest or pytest binary.
965b7cc to
2aa6d29
Compare
变更内容
main,四向/八向工作流统一使用全部真实生成方向。变更范围
main仅修改 4 个前端文件。验证
font-delivery.test.ts):1046 项通过。font-delivery.test.ts在 Windows 将file:路径误解析为普通路径,单独运行稳定失败;该文件及其实现不在本 PR 差异中。Closes #606
Refs #544
Refs #222