Skip to content

feat(workflow): 按全部方向编排生成任务 - #579

Merged
huyanxius merged 4 commits into
1024XEngineer:mainfrom
xyh202131:feat/full-direction-workflow-controller
Aug 24, 2026
Merged

huyanxius merged 4 commits into
1024XEngineer:mainfrom
xyh202131:feat/full-direction-workflow-controller

Conversation

@xyh202131

@xyh202131 xyh202131 commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

变更内容

  • 同步已合入 feat(generation): 四向八向使用全方向独立合同 #577 的最新 main,四向/八向工作流统一使用全部真实生成方向。
  • Workflow Controller 只提交尚未确认或缺失的方向;单方向提交失败时保留其它已创建任务引用,重试不会重复提交成功方向。
  • Quick Start 上传单张母版时只确认东向,多方向项目继续生成其余方向,全部确认前不提前进入动作生成。
  • 多方向 Character 写入失败时保留当前方向选择并支持幂等重试;单向流程继续使用原有节点重开恢复。
  • 沿用现有 Workflow/Quick Start 的增加动作入口,不引入第二套流程。

变更范围

  • 相对最新 main 仅修改 4 个前端文件。
  • 后端差异为 0;不包含工程文件、压缩包或文档产物。

验证

  • 定向测试:151 项通过。
  • 前端覆盖率测试(排除 Windows 下路径解析失败的 font-delivery.test.ts):1046 项通过。
  • 覆盖率:Statements 92.21%,Branches 86.68%,Functions 95.86%,Lines 95.20%。
  • Workflow Controller 行覆盖率 95.96%,Quick Start Service 行覆盖率 94.11%。
  • TypeScript 类型检查、Lint、4 个改动文件格式检查、生产构建通过。
  • font-delivery.test.ts 在 Windows 将 file: 路径误解析为普通路径,单独运行稳定失败;该文件及其实现不在本 PR 差异中。

Closes #606
Refs #544
Refs #222

@vercel

vercel Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 24, 2026 8:04am

@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

✅ 此 PR 已关联 issue,之前的提醒已自动标记为已解决。

@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...end/src/features/workflow-controller/controller.ts 85.18% 1 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@xyh202131

Copy link
Copy Markdown
Contributor Author

/review

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff, including the direction contract, workflow controller, backend validation, and asset publication paths. The new controller correctly schedules all required directions, but the profile migration leaves existing publication/quick-start consumers on the legacy sourceDirections list, so multi-direction results are not preserved end to end. git diff --check passes; local test runners were unavailable because the frontend vitest binary is non-executable and backend pytest is not installed.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller/backend now create real generation tasks for all four/eight directions, but the editor/export path still consumes sourceDirections, which remains the legacy 3/5-direction subset. As a result, newly generated west/diagonal results are not rendered or selected in Workflow Editor and are not required/published by the export path, so a run can appear complete while silently dropping those assets. The profile needs one consistent set of required real directions across generation, UI, and publication (or all consumers must be migrated to the new field).

Verification was limited to static call-site tracing because the checkout has no executable vitest or pytest binary.

@xyh202131
xyh202131 force-pushed the feat/full-direction-workflow-controller branch from 965b7cc to 2aa6d29 Compare August 24, 2026 05:25
@huyanxius
huyanxius merged commit 61f6f0f into 1024XEngineer:main Aug 24, 2026
9 checks passed

This branch was successfully deployed

1 active deployment
Preview — bffe42a2 Deployed Aug 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(workflow): 补齐全方向任务调度与上传母版恢复

2 participants