chore: drop legacy // +build comment#2260
Conversation
Signed-off-by: solunolab <solunolab@outlook.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
This failure does not seem related to this PR. The PR only removes legacy I checked the failing test locally on this branch:
Both passed. The failure looks like a flaky race in the test itself: I think rerunning CI should be enough here. If you prefer, I can also open a separate follow-up PR to make this test avoid counting background probe hits as failover attempts. @pratikspatil024 @kamuikatsurgi Hi, Would you mind review this PR at your convenience? Thank you very much. |
1 participant
Summary
From Go 1.17, the preferred syntax for build constraints is //go:build,
which replaces the old // +build form. The old style is now considered
deprecated but still supported for backward compatibility.
This change removes the obsolete // +build xxx line, keeping only the
modern //go:build xxx directive.
More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines
Design Doc / Proposal：
https://go.dev/design/draft-gobuild
Inspired by #1931
Executed tests
<what was actually run beyond CI's standard unit / integration / e2e gates: kurtosis scenarios, chaos runs, manual checks against Amoy / mainnet RPCs, devnet upgrades, etc. Include output or pointers to where the run lives.>
Rollout notes
<consensus-affecting? requires coordinated upgrade? backwards-compatible? operator-facing change?>