Skip to content

typings install is run on postinstall causing build to fail. #5

Description

@aluanhaddad

The command typings install is executed when installing the package. This causes builds to fail as typings is listed under "devDepenencies" and is therefore not installed.

If this was fixed by moving typings to "dependencies", it will likely cause issues because the typings for es6-shim modify the global namespace and will collide with declarations provided by TypeScript itself such as when specifying the lib option in tsconfig.compilerOptions.

Since es6-shim is not a dependency, its typings should also not be required. In general, polyfill typings, including those provided by npm:@types packages should be avoided where at all possible in favour of the tsconfig.compilerOptions.lib

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions