Skip to content

Commit 81163eb

Browse files
committed
docs: clean up comments in ForthToMemRef conversion
1 parent 8496399 commit 81163eb

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

‎lib/Conversion/ForthToMemRef/ForthToMemRef.cpp‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ struct BinaryCmpOpConversion : public OpConversionPattern<ForthOp> {
488488
// Compare
489489
Value cmp = rewriter.create<arith::CmpIOp>(loc, predicate, a, b);
490490

491-
// Extend i1 to i64: true → -1 (all bits set), false → 0
491+
// Extend i1 to i64: true = -1 (all bits set), false = 0
492492
Value result =
493493
rewriter.create<arith::ExtSIOp>(loc, rewriter.getI64Type(), cmp);
494494

@@ -570,7 +570,7 @@ struct ZeroEqOpConversion : public OpConversionPattern<forth::ZeroEqOp> {
570570
Value cmp =
571571
rewriter.create<arith::CmpIOp>(loc, arith::CmpIPredicate::eq, a, zero);
572572

573-
// Extend i1 to i64: true → -1, false → 0
573+
// Extend i1 to i64: true = -1, false = 0
574574
Value result =
575575
rewriter.create<arith::ExtSIOp>(loc, rewriter.getI64Type(), cmp);
576576

@@ -862,7 +862,7 @@ struct IfOpConversion : public OpConversionPattern<forth::IfOp> {
862862
/*addElseBlock=*/true);
863863

864864
// Convert block signatures and inline regions into scf.if.
865-
// convertRegionTypes converts !forth.stack block arg → {memref, index}
865+
// convertRegionTypes converts !forth.stack block arg to {memref, index}
866866
// and inserts tracked materializations (unrealized_conversion_cast).
867867
// We inline into scf.if and mergeBlocks to substitute the converted
868868
// block args with parent-scope values. The original materialization
@@ -918,7 +918,7 @@ struct BeginUntilOpConversion
918918
auto whileOp = rewriter.create<scf::WhileOp>(loc, TypeRange{indexType},
919919
ValueRange{stackPtr});
920920

921-
// --- Before region (body): convert + inline ---
921+
// Before region (body): convert + inline.
922922
Region &bodyRegion = op.getBodyRegion();
923923
if (failed(rewriter.convertRegionTypes(&bodyRegion, *getTypeConverter())))
924924
return failure();
@@ -936,7 +936,7 @@ struct BeginUntilOpConversion
936936
Value beforeSP = newBeforeBlock->getArgument(0);
937937
rewriter.mergeBlocks(&beforeBlock, newBeforeBlock, {memref, beforeSP});
938938

939-
// --- After region (identity): just yield the SP ---
939+
// After region (identity): just yield the SP.
940940
Block *afterBlock = rewriter.createBlock(&whileOp.getAfter());
941941
afterBlock->addArgument(indexType, loc);
942942
Value afterSP = afterBlock->getArgument(0);
@@ -974,7 +974,7 @@ struct BeginWhileRepeatOpConversion
974974
auto whileOp = rewriter.create<scf::WhileOp>(loc, TypeRange{indexType},
975975
ValueRange{stackPtr});
976976

977-
// --- Before region (condition): convert + inline ---
977+
// Before region (condition): convert + inline.
978978
Region &condRegion = op.getConditionRegion();
979979
if (failed(rewriter.convertRegionTypes(&condRegion, *getTypeConverter())))
980980
return failure();
@@ -988,7 +988,7 @@ struct BeginWhileRepeatOpConversion
988988
Value beforeSP = newBeforeBlock->getArgument(0);
989989
rewriter.mergeBlocks(&beforeBlock, newBeforeBlock, {memref, beforeSP});
990990

991-
// --- After region (body): convert + inline ---
991+
// After region (body): convert + inline.
992992
Region &bodyRegion = op.getBodyRegion();
993993
if (failed(rewriter.convertRegionTypes(&bodyRegion, *getTypeConverter())))
994994
return failure();
@@ -1034,7 +1034,7 @@ struct DoLoopOpConversion : public OpConversionPattern<forth::DoLoopOp> {
10341034
Value limitI64 = rewriter.create<memref::LoadOp>(loc, memref, spAfterStart);
10351035
Value spAfterPops = rewriter.create<arith::SubIOp>(loc, spAfterStart, one);
10361036

1037-
// Cast i64 → index for scf.for bounds
1037+
// Cast i64 to index for scf.for bounds
10381038
Value startIdx =
10391039
rewriter.create<arith::IndexCastOp>(loc, indexType, startI64);
10401040
Value limitIdx =
@@ -1095,7 +1095,7 @@ struct LoopIndexOpConversion : public OpConversionPattern<forth::LoopIndexOp> {
10951095
if (!forOp)
10961096
return rewriter.notifyMatchFailure(op, "not inside an scf.for");
10971097

1098-
// Get induction variable and cast index → i64
1098+
// Get induction variable and cast index to i64
10991099
Value iv = forOp.getInductionVar();
11001100
Value ivI64 =
11011101
rewriter.create<arith::IndexCastOp>(loc, rewriter.getI64Type(), iv);

0 commit comments

Comments
 (0)