Encountering recursion error when trying to publish to Google Cloud Run

[csbryan99]

Hi all, Datasette and Python novice here -

I'm currently encountering a recursion error when I try to publish my .db file to Google Cloud Run as follows:

py -m datasette publish cloudrun twitter.db --service=service-name

When I run this in the terminal I get the following error output (repeated ad infinitum):

File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 626, in _rmtree_unsafe onerror(os.rmdir, path, sys.exc_info()) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\tempfile.py", line 881, in onerror cls._rmtree(path, ignore_errors=ignore_errors) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\tempfile.py", line 890, in _rmtree _shutil.rmtree(name, onerror=onerror) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 626, in _rmtree_unsafe onerror(os.rmdir, path, sys.exc_info()) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\tempfile.py", line 881, in onerror cls._rmtree(path, ignore_errors=ignore_errors) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\tempfile.py", line 890, in _rmtree _shutil.rmtree(name, onerror=onerror) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 759, in rmtree return _rmtree_unsafe(path, onerror) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\shutil.py", line 626, in _rmtree_unsafe onerror(os.rmdir, path, sys.exc_info()) File "C:\Users\cbryan\AppData\Local\Programs\Python\Python311\Lib\tempfile.py", line 875, in onerror resetperms(path) RecursionError: maximum recursion depth exceeded

Happy to provide any additional info as needed - I am running Python 3.11.2 and datasette 0.64.2 on Windows 10.

[Muguett-DBY]

That repeated traceback is from temporary-directory cleanup. One likely cause is Datasette's working-directory handling on Windows: in 0.64.2's publish helper, tmp.cleanup() runs before os.chdir(saved_cwd). Windows won't remove the directory while it is the process's current directory.

The cleanup block needs the opposite order:

finally:
    os.chdir(saved_cwd)
    tmp.cleanup()

I reproduced this cleanup bug on Windows with Python 3.12 and submitted #3012, which is still open. I haven't reproduced your exact Python 3.11.2 / Cloud Run deployment.

If there is a gcloud error before the first cleanup traceback, please include that part too: cleanup can obscure an earlier publishing error, so fixing it doesn't by itself establish that the deployment succeeded.

Checked with Codex.