Commit f6fe2a3
fix(types): type-check the shipped source against React Native 0.87
The package's "types" entry is src/index.ts, so consumer projects compile
this source with their own compiler options and skipLibCheck does not
cover it. Against RN 0.87's globals it failed in three places:
- client.ts requestCheckResult merged the caller's AbortSignal into the
RequestInit. With RN 0.87 plus DOM-style fetch types (@types/bun, which
loads Node's), the global AbortSignal and RequestInit.signal come from
different declarations and the spread is rejected (onabort nullable vs
not). fetchWithTimeout now takes the caller's signal as its own
argument and chains it as before; params.signal still works.
- setTimeout(resolve) in the logger wait and retry backoff: RN 0.87 types
the callback as () => void. Wrap the resolve call.
- core.ts used `global`, which RN 0.87's typings no longer declare (only
@types/node did). Declare it module-locally; no runtime change.
Verified with tsc on RN 0.87.1 and react-native-tvos 0.87.1-1 projects
(template tsconfig; with types ["bun"], ["jest","node"]; with the DOM lib)
and an Expo 58 preview project. With the 10.58.0 source, the plain
template fails on setTimeout and `global`, types ["bun"] fails on the
signal, and the DOM-lib and Expo configs fail on `global`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 83869ff commit f6fe2a3
4 files changed
Lines changed: 44 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
151 | 175 | | |
152 | 176 | | |
153 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
742 | 742 | | |
743 | 743 | | |
744 | 744 | | |
745 | | - | |
746 | | - | |
| 745 | + | |
| 746 | + | |
747 | 747 | | |
748 | 748 | | |
749 | 749 | | |
| |||
977 | 977 | | |
978 | 978 | | |
979 | 979 | | |
980 | | - | |
981 | | - | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
982 | 983 | | |
983 | 984 | | |
984 | 985 | | |
| |||
1532 | 1533 | | |
1533 | 1534 | | |
1534 | 1535 | | |
1535 | | - | |
| 1536 | + | |
1536 | 1537 | | |
1537 | 1538 | | |
1538 | 1539 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
6 | 12 | | |
7 | 13 | | |
8 | 14 | | |
9 | 15 | | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
13 | | - | |
| 19 | + | |
14 | 20 | | |
15 | 21 | | |
16 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
136 | 140 | | |
137 | 141 | | |
138 | 142 | | |
| |||
161 | 165 | | |
162 | 166 | | |
163 | 167 | | |
164 | | - | |
| 168 | + | |
| 169 | + | |
165 | 170 | | |
166 | 171 | | |
167 | 172 | | |
| |||
0 commit comments