fix: repair failing tests and type errors across api and shared

- Implement paginate() in shared (was a stub); guard non-finite page/size
- Reconcile User field name to `username` across api and shared
- Add missing badRequest import in users route (fixes 400 handler)
- Fix case-sensitive HTTP method check in auth middleware public routes
- Wire up bun-types in tsconfig so process/bun:test resolve

All 22 tests pass; tsc --noEmit is clean.

Author: QuantCode Agent

packages/api/src/middleware/auth.ts

@@ -6,18 +6,11 @@ import type { MiddlewareHandler } from "hono"
  * Policy:
  *   GET, POST  → public (no token required)
  *   PUT, DELETE, PATCH → require Bearer token
- *
- * BUG: The allow-list check uses `'post'` (lowercase) instead of `'POST'`.
- * HTTP methods are always uppercase per RFC 7231, so POST is never matched
- * as a public method — POST requests incorrectly require a token.
- *
- * Fix: change `'post'` to `'POST'` in the public methods array.
  */
 export const authMiddleware: MiddlewareHandler = async (c, next) => {
-  // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+  const publicMethods = ["GET", "POST"]
 
-  if (publicMethods.includes(c.req.method)) {
+  if (publicMethods.includes(c.req.method.toUpperCase())) {
     return next()
   }
 

packages/api/src/routes/users.ts

@@ -1,9 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
-// BUG: missing import — `badRequest` is used below but not imported here.
-// This causes a ReferenceError at runtime when POST /users is called with invalid data.
-// Fix: add `badRequest` to the import from "../lib/errors"
+import { badRequest, notFound } from "../lib/errors"
 
 const router = new Hono()
 
@@ -20,7 +17,6 @@ router.get("/:id", (c) => {
 router.post("/", async (c) => {
   const body = await c.req.json().catch(() => null)
   if (!body || !body.username || !body.email) {
-    // BUG: badRequest is not imported — this will throw ReferenceError
     return badRequest(c, "username and email are required")
   }
   const user = db.users.create({ username: body.username, email: body.email })

packages/shared/src/types.ts

@@ -1,14 +1,10 @@
 /**
  * Shared types used by both the API and any consumers.
- *
- * BUG: The field is named `userName` here but the API routes reference `username`
- * (lowercase n). This causes a type error in routes/users.ts and a runtime
- * mismatch when serialising responses.
  */
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }

packages/shared/src/utils/pagination.ts

@@ -1,15 +1,30 @@
 import type { PaginatedResponse } from "../types"
 
+const DEFAULT_PAGE_SIZE = 10
+
 /**
  * Paginate an array of items.
  *
+ * Non-finite inputs (NaN, Infinity) are rejected rather than clamped, since
+ * Math.max(1, NaN) is NaN and Math.floor(Infinity) is Infinity — either would
+ * break the numeric contract or return the whole dataset in one page.
+ *
  * @param items  Full array of items
  * @param page   1-indexed page number
  * @param size   Number of items per page
- *
- * TODO: implement this function — it is currently a stub.
- * The test in packages/shared/test/pagination.test.ts exercises the full contract.
  */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const pageSize = Number.isFinite(size) ? Math.max(1, Math.floor(size)) : DEFAULT_PAGE_SIZE
+  const currentPage = Number.isFinite(page) ? Math.max(1, Math.floor(page)) : 1
+  const totalPages = Math.ceil(total / pageSize)
+  const start = (currentPage - 1) * pageSize
+
+  return {
+    data: items.slice(start, start + pageSize),
+    total,
+    page: currentPage,
+    pageSize,
+    totalPages,
+  }
 }

tsconfig.json

@@ -5,6 +5,7 @@
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/shared": ["./packages/shared/src/index.ts"]
     }