fix: repair failing tests and type errors across api and shared packages

- auth: fix HTTP method case-sensitivity in public-methods allow-list ("post" -> "POST") so POST requests are correctly treated as public
- users route: add missing badRequest import causing ReferenceError/TS2552
- shared types: rename User.userName -> username to match the test contract and align both packages
- pagination: implement paginate<T> per its test contract, with clamping/guards for non-finite and out-of-range page/size
- tsconfig: add "bun-types" to types so bun:test and process globals resolve

Author: QuantCode Agent

packages/api/src/middleware/auth.ts

@@ -6,16 +6,9 @@ import type { MiddlewareHandler } from "hono"
  * Policy:
  *   GET, POST  → public (no token required)
  *   PUT, DELETE, PATCH → require Bearer token
- *
- * BUG: The allow-list check uses `'post'` (lowercase) instead of `'POST'`.
- * HTTP methods are always uppercase per RFC 7231, so POST is never matched
- * as a public method — POST requests incorrectly require a token.
- *
- * Fix: change `'post'` to `'POST'` in the public methods array.
  */
 export const authMiddleware: MiddlewareHandler = async (c, next) => {
-  // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+  const publicMethods = ["GET", "POST"]
 
   if (publicMethods.includes(c.req.method)) {
     return next()

packages/api/src/routes/users.ts

@@ -1,9 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
-// BUG: missing import — `badRequest` is used below but not imported here.
-// This causes a ReferenceError at runtime when POST /users is called with invalid data.
-// Fix: add `badRequest` to the import from "../lib/errors"
+import { notFound, badRequest } from "../lib/errors"
 
 const router = new Hono()
 
@@ -20,7 +17,6 @@ router.get("/:id", (c) => {
 router.post("/", async (c) => {
   const body = await c.req.json().catch(() => null)
   if (!body || !body.username || !body.email) {
-    // BUG: badRequest is not imported — this will throw ReferenceError
     return badRequest(c, "username and email are required")
   }
   const user = db.users.create({ username: body.username, email: body.email })

packages/shared/src/types.ts

@@ -1,14 +1,10 @@
 /**
  * Shared types used by both the API and any consumers.
- *
- * BUG: The field is named `userName` here but the API routes reference `username`
- * (lowercase n). This causes a type error in routes/users.ts and a runtime
- * mismatch when serialising responses.
  */
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }

packages/shared/src/utils/pagination.ts

@@ -1,15 +1,35 @@
 import type { PaginatedResponse } from "../types"
 
+function toPositiveInt(value: number): number {
+  if (!Number.isFinite(value)) return 1
+  const floored = Math.floor(value)
+  return floored < 1 ? 1 : floored
+}
+
 /**
  * Paginate an array of items.
  *
- * @param items  Full array of items
- * @param page   1-indexed page number
- * @param size   Number of items per page
+ * `page` and `size` are truncated to integers and clamped to a minimum of 1.
+ * Non-finite values (`NaN`, `Infinity`, `-Infinity`) and values below 1 fall
+ * back to 1, so untrusted input such as `Number(query.page)` can never leak
+ * `NaN` into the response.
  *
- * TODO: implement this function — it is currently a stub.
- * The test in packages/shared/test/pagination.test.ts exercises the full contract.
+ * @param items  Full array of items
+ * @param page   1-indexed page number; defaults to 1 if non-finite or < 1
+ * @param size   Number of items per page; defaults to 1 if non-finite or < 1
  */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const pageSize = toPositiveInt(size)
+  const currentPage = toPositiveInt(page)
+  const totalPages = Math.ceil(total / pageSize)
+  const start = (currentPage - 1) * pageSize
+
+  return {
+    data: items.slice(start, start + pageSize),
+    page: currentPage,
+    pageSize,
+    total,
+    totalPages,
+  }
 }

tsconfig.json

@@ -5,6 +5,7 @@
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/shared": ["./packages/shared/src/index.ts"]
     }