From d2d0554a2cf9bbfb78dccbdb4b173f9812d21c26 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sat, 12 Sep 2026 16:21:17 +0000
Subject: [PATCH] fix: resolve cross-package test failures and type errors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- api: import renamed useDebounce hook and re-export as useSearchDebounce
  (was importing non-existent useThrottle, breaking api.test and typecheck)
- Button: forward aria-label to the rendered button for icon-only buttons,
  with a dev warning + fallback so an accessible name is always present (WCAG 4.1.2)
- DataTable: use functional state updater for sort direction to fix stale
  closure so asc→desc toggles on the second header click
- date: strip zero-padding on the day part while keeping en-AU day-first
  ordering (1/03/2024 instead of 01/03/2024)
---
 apps/web/src/lib/api.ts                       | 12 +++-------
 packages/ui/src/components/Button/Button.tsx  | 22 +++++++++++--------
 .../ui/src/components/DataTable/DataTable.tsx | 11 +---------
 packages/utils/src/format/date.ts             | 19 ++++++++--------
 4 files changed, 26 insertions(+), 38 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..d9c4314 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..ba03b71 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,14 +17,13 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button renders no visible text, so it must expose an
+ * `aria-label` to have an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value).
+ * When `iconOnly` is set without an explicit label we warn in development and
+ * fall back to a generic label so the button is never left unnamed.
  */
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
 export function Button({
   children,
   icon,
@@ -34,13 +33,18 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn("Button: `aria-label` is required when `iconOnly` is true (WCAG 2.2 SC 4.1.2)")
+  }
+
+  const label = iconOnly ? (ariaLabel ?? ICON_ONLY_FALLBACK_LABEL) : ariaLabel
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={label}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..e6ba613 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -15,23 +15,14 @@ type Props<T extends Record<string, unknown>> = {
 
 /**
  * DataTable with client-side sorting.
- *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..6b58efa 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,20 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `formatDate` produces Australian day-first dates (D/MM/YYYY). The day is
+ * rendered without zero-padding, so 1 March 2024 formats as `1/03/2024`.
+ * `en-AU` pads the day whenever the month is numeric, so the day part is
+ * un-padded here while the locale keeps the field ordering.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  })
+    .formatToParts(date)
+    .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {