Several call sites in pyro_camera_api use cam_id as a loop variable when iterating dicts keyed by camera IP (CAMERA_REGISTRY, PATROL_FLAGS, STUCK_CHECK_FLAGS, stream_workers, stream_processes, RAW_CONFIG, ...). This is misleading: cam_id is used elsewhere in the project for the camera-pose identifier ("{ip}_{p}"), not for plain IPs.
The loop functions in camera/patrol.py and camera/stuck_detector.py already use camera_ip correctly — the call sites should match.
Files to update: pyro_camera_api/main.py, api/routes_stream.py, api/routes_cameras.py.
Pure rename, no behavior change. Spotted while reviewing #360.
Several call sites in pyro_camera_api use
cam_idas a loop variable when iterating dicts keyed by camera IP (CAMERA_REGISTRY,PATROL_FLAGS,STUCK_CHECK_FLAGS,stream_workers,stream_processes,RAW_CONFIG, ...). This is misleading:cam_idis used elsewhere in the project for the camera-pose identifier ("{ip}_{p}"), not for plain IPs.The loop functions in
camera/patrol.pyandcamera/stuck_detector.pyalready usecamera_ipcorrectly — the call sites should match.Files to update:
pyro_camera_api/main.py,api/routes_stream.py,api/routes_cameras.py.Pure rename, no behavior change. Spotted while reviewing #360.