Merge pull request #1540 from opencomponents/fix/registry-env-value-types

Allow arbitrary registry environment value types

Author: ricardo-devis-agullo

.changeset/registry-env-booleans.md

@@ -0,0 +1,5 @@
+---
+"oc": patch
+---
+
+Allow registry environment values passed to component `context.env` to use arbitrary JavaScript value types.

packages/oc/src/types.ts

@@ -307,11 +307,12 @@ export interface Config<
    */
   discoveryFunc?: (opts: { host?: string; secure: boolean }) => boolean;
   /**
-   * Environment variables passed to components in `context.env`.
+   * Environment values passed to components in `context.env` and the data
+   * provider's `process.env` shim.
    *
    * @default {}
    */
-  env: Record<string, string>;
+  env: Record<string, any>;
   /**
    * Maximum execution time of a component’s server-side logic, expressed in
    * seconds. When the timeout elapses the registry returns a 500 error.

packages/oc/test/fixtures/mocked-components/env.js

@@ -20,7 +20,7 @@ module.exports = {
       }
     }
   },
-  data: '"use strict";module.exports.data=function (ctx, cb){cb(null,{ mySecret:ctx.env.secret});};',
+  data: '"use strict";module.exports.data=function (ctx, cb){cb(null,{ mySecret:ctx.env.secret, contextBoolean:ctx.env.booleanValue, processBoolean:process.env.booleanValue});};',
   view:
     'var oc=oc||{};oc.components=oc.components||{},oc.components["8c1fbd954f2b0d8cd5cf11c885fed4805225749f"]' +
     '=function(){var o=[];return o.push("<div>hello</div>"),o.join("")};'

packages/oc/test/unit/registry-routes-helpers-get-component.js

@@ -90,7 +90,7 @@ describe('registry : routes : helpers : get-component', () => {
           parameters: {},
           version: '1.X.X',
           conf: {
-            env: { registry: 'REGISTRYVALUE' },
+            env: { registry: 'REGISTRYVALUE', booleanValue: false },
             baseUrl: 'http://components.com/'
           }
         },
@@ -100,7 +100,9 @@ describe('registry : routes : helpers : get-component', () => {
 
     it('should put the env data as part of the context, available to the server', () => {
       expect(callBack.args[0][0].response.data).to.deep.equal({
-        mySecret: 'secretvalue'
+        mySecret: 'secretvalue',
+        contextBoolean: false,
+        processBoolean: false
       });
     });
   });