@@ -7,6 +7,7 @@ import { activateSurface, resetDeviceSurfaceForTest, surfaceIdForDevice } from '
77import { AssistantProjectFolderError , ProjectDirectoryUnavailableError } from '@/app/utils/projectDraft' ;
88import { globalAPI , type WorkspaceInfo } from '@/infrastructure/api/service-api/GlobalAPI' ;
99import type { WorkspaceSourceOption } from '@/features/ssh-remote/useWorkspaceSourceOptions' ;
10+ import { sshApi } from '@/features/ssh-remote/sshApi' ;
1011import { PeerDeviceContext , type PeerDeviceContextValue } from '@/infrastructure/peer-device/peerDeviceContextState' ;
1112
1213globalThis . IS_REACT_ACT_ENVIRONMENT = true ;
@@ -15,10 +16,10 @@ vi.mock('@/infrastructure/api/service-api/RemoteConnectAPI', async importOrigina
1516 remoteConnectAPI : { getDeviceInfo : async ( ) => ( { device_id : 'local' , device_name : 'Workstation' , device_os : 'macOS' } ) } ,
1617} ) ) ;
1718const wslSupport = vi . hoisted ( ( ) => ( { supported : true } ) ) ;
18- vi . mock ( '@/features/ssh-remote/sshApi' , ( ) => ( { sshApi : { listWslDistributions : async ( ) => ( { supported : wslSupport . supported , distributions : [ ] } ) } } ) ) ;
19- const { pickDirectory, sourceOptions, optionsBySource } = vi . hoisted ( ( ) => ( { pickDirectory : vi . fn ( ) , sourceOptions : [ ] as WorkspaceSourceOption [ ] , optionsBySource : { } as Record < string , WorkspaceSourceOption [ ] > } ) ) ;
19+ vi . mock ( '@/features/ssh-remote/sshApi' , ( ) => ( { sshApi : { deleteConnection : vi . fn ( ) , listWslDistributions : async ( ) => ( { supported : wslSupport . supported , distributions : [ ] } ) } } ) ) ;
20+ const { pickDirectory, sourceOptions, optionsBySource, refreshOptions } = vi . hoisted ( ( ) => ( { pickDirectory : vi . fn ( ) , sourceOptions : [ ] as WorkspaceSourceOption [ ] , optionsBySource : { } as Record < string , WorkspaceSourceOption [ ] > , refreshOptions : vi . fn ( ) } ) ) ;
2021vi . mock ( '@/features/ssh-remote/useWorkspaceSourceOptions' , ( ) => ( {
21- useWorkspaceSourceOptions : ( source : string ) => ( { options : optionsBySource [ source ] || [ ] , loading : false , error : '' , refresh : vi . fn ( ) } ) ,
22+ useWorkspaceSourceOptions : ( source : string ) => ( { options : optionsBySource [ source ] || [ ] , loading : false , error : '' , refresh : ( ) => refreshOptions ( source ) } ) ,
2223 workspacePresetHost : ( preset ?: { kind : string ; connection ?: unknown } ) => preset ?. kind === 'saved' ? preset . connection : undefined ,
2324} ) ) ;
2425vi . mock ( '@/infrastructure/i18n' , ( ) => ( { useI18n : ( ) => ( { t : ( key : string , options ?: { name ?: string } ) =>
@@ -61,11 +62,12 @@ describe('NewProjectDialog composition', () => {
6162 beforeEach ( ( ) => {
6263 vi . resetAllMocks ( ) ;
6364 vi . spyOn ( globalAPI , 'getRecentWorkspaces' ) . mockResolvedValue ( [ ] ) ;
65+ vi . spyOn ( globalAPI , 'removeRecentWorkspace' ) . mockResolvedValue ( undefined ) ;
6466 wslSupport . supported = true ;
6567 sourceOptions . length = 0 ;
6668 for ( const key of Object . keys ( optionsBySource ) ) delete optionsBySource [ key ] ;
6769 for ( const source of [ 'ssh' , 'wsl' , 'localDocker' , 'remoteDocker' ] ) {
68- optionsBySource [ source ] = [ { id : `fixture-${ source } ` , label : source , preset : { kind : 'saved' , connection : {
70+ optionsBySource [ source ] = [ { id : `fixture-${ source } ` , savedConnectionId : `fixture- ${ source } ` , label : source , preset : { kind : 'saved' , connection : {
6971 id : `fixture-${ source } ` , name : source , host : 'host.test' , port : 22 , username : 'dev' , authType : { type : 'PrivateKey' , keyPath : '/keys/dev' } ,
7072 } } } ] ;
7173 }
@@ -219,12 +221,57 @@ describe('NewProjectDialog composition', () => {
219221 const pick = vi . fn ( ) ;
220222 await render ( { onPickRemoteFolder : pick , onSelectRemoteHost : selectHost } ) ;
221223 selectSource ( 'ssh' , false ) ;
224+ expect ( document . querySelector ( 'button[aria-label="actions.delete · Build host"]' ) ) . toBeNull ( ) ;
222225 await act ( async ( ) => document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.edit · Build host"]' ) ! . click ( ) ) ;
223226 expect ( selectHost ) . toHaveBeenCalledWith ( 'ssh' , { ...option . preset , edit : true } ) ;
224227 expect ( document . querySelector ( '[data-workspace-choice="host"] button[aria-pressed]' ) ?. getAttribute ( 'aria-pressed' ) ) . toBe ( 'false' ) ;
225228 expect ( pick ) . not . toHaveBeenCalled ( ) ;
226229 } ) ;
227230
231+ it ( 'deletes a selected saved host without connecting and clears its project selection' , async ( ) => {
232+ let finish ! : ( ) => void ;
233+ vi . mocked ( sshApi . deleteConnection ) . mockReturnValue ( new Promise ( resolve => { finish = resolve ; } ) ) ;
234+ const selectHost = vi . fn ( ) ;
235+ await render ( { onPickRemoteFolder : vi . fn ( ) , onSelectRemoteHost : selectHost } ) ;
236+ selectSource ( 'ssh' ) ;
237+ enterName ( 'Remote project' ) ;
238+ expect ( button ( 'newProject.create' ) . disabled ) . toBe ( false ) ;
239+ const remove = document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · ssh"]' ) ! ;
240+ expect ( remove . closest ( 'button' ) ?. parentElement ?. closest ( 'button' ) ) . toBeNull ( ) ;
241+ await act ( async ( ) => remove . click ( ) ) ;
242+ expect ( sshApi . deleteConnection ) . toHaveBeenCalledExactlyOnceWith ( 'fixture-ssh' ) ;
243+ expect ( remove . disabled ) . toBe ( true ) ;
244+ expect ( selectHost ) . not . toHaveBeenCalled ( ) ;
245+ expect ( refreshOptions ) . not . toHaveBeenCalled ( ) ;
246+ await act ( async ( ) => finish ( ) ) ;
247+ expect ( refreshOptions ) . toHaveBeenCalledWith ( 'ssh' ) ;
248+ expect ( document . querySelector ( '[data-workspace-choice="fixture-ssh"] button[aria-pressed]' ) ?. getAttribute ( 'aria-pressed' ) ) . toBe ( 'false' ) ;
249+ expect ( button ( 'newProject.create' ) . disabled ) . toBe ( true ) ;
250+ } ) ;
251+
252+ it ( 'retains the saved host and its selection when deletion fails' , async ( ) => {
253+ vi . mocked ( sshApi . deleteConnection ) . mockRejectedValue ( new Error ( 'Host offline' ) ) ;
254+ await render ( { onPickRemoteFolder : vi . fn ( ) , onSelectRemoteHost : vi . fn ( ) } ) ;
255+ selectSource ( 'ssh' ) ;
256+ await act ( async ( ) => document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · ssh"]' ) ! . click ( ) ) ;
257+ expect ( document . querySelector ( '[role="alert"]' ) ?. textContent ) . toContain ( 'Host offline' ) ;
258+ expect ( document . querySelector ( '[data-workspace-choice="fixture-ssh"] button[aria-pressed]' ) ?. getAttribute ( 'aria-pressed' ) ) . toBe ( 'true' ) ;
259+ expect ( refreshOptions ) . not . toHaveBeenCalled ( ) ;
260+ } ) ;
261+
262+ it ( 'ignores a completed deletion after switching device surfaces' , async ( ) => {
263+ let finish ! : ( ) => void ;
264+ vi . mocked ( sshApi . deleteConnection ) . mockReturnValue ( new Promise ( resolve => { finish = resolve ; } ) ) ;
265+ await render ( { onPickRemoteFolder : vi . fn ( ) , onSelectRemoteHost : vi . fn ( ) } ) ;
266+ selectSource ( 'ssh' ) ;
267+ await act ( async ( ) => document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · ssh"]' ) ! . click ( ) ) ;
268+ act ( ( ) => activateSurface ( surfaceIdForDevice ( 'peer' ) ) ) ;
269+ await act ( async ( ) => finish ( ) ) ;
270+ expect ( refreshOptions ) . not . toHaveBeenCalled ( ) ;
271+ expect ( document . querySelector ( '[role="alert"]' ) ) . toBeNull ( ) ;
272+ expect ( sshApi . deleteConnection ) . toHaveBeenCalledTimes ( 1 ) ;
273+ } ) ;
274+
228275 const recentWorkspace = ( id : string , extra : Partial < WorkspaceInfo > = { } ) : WorkspaceInfo => ( {
229276 id, name : id , rootPath : `/work/${ id } ` , workspaceKind : 'normal' , workspaceType : 'singleProject' ,
230277 languages : [ ] , tags : [ ] , openedAt : '2026-01-01' , lastAccessed : '2026-01-01' , ...extra ,
@@ -260,6 +307,46 @@ describe('NewProjectDialog composition', () => {
260307 expect ( document . querySelector ( '[data-workspace-choice="controller-private"]' ) ) . toBeNull ( ) ;
261308 } ) ;
262309
310+ it ( 'removes a recent workspace without selecting its folder or creating a project' , async ( ) => {
311+ vi . mocked ( globalAPI . getRecentWorkspaces ) . mockResolvedValue ( [ recentWorkspace ( 'one' ) , recentWorkspace ( 'two' ) ] ) ;
312+ let finish ! : ( ) => void ;
313+ vi . mocked ( globalAPI . removeRecentWorkspace ) . mockReturnValue ( new Promise ( resolve => { finish = resolve ; } ) ) ;
314+ await render ( { onPickRemoteFolder : vi . fn ( ) } ) ;
315+ const remove = document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · one"]' ) ! ;
316+ await act ( async ( ) => remove . click ( ) ) ;
317+ expect ( globalAPI . removeRecentWorkspace ) . toHaveBeenCalledExactlyOnceWith ( 'one' ) ;
318+ expect ( remove . disabled ) . toBe ( true ) ;
319+ expect ( document . querySelector ( '[data-workspace-choice="one"]' ) ) . not . toBeNull ( ) ;
320+ await act ( async ( ) => finish ( ) ) ;
321+ expect ( document . querySelector ( '[data-workspace-choice="one"]' ) ) . toBeNull ( ) ;
322+ expect ( document . querySelector ( '[data-workspace-choice="two"]' ) ) . not . toBeNull ( ) ;
323+ expect ( document . querySelectorAll ( '.new-project-dialog__folder li' ) ) . toHaveLength ( 0 ) ;
324+ expect ( confirm ) . not . toHaveBeenCalled ( ) ;
325+ expect ( pickDirectory ) . not . toHaveBeenCalled ( ) ;
326+ } ) ;
327+
328+ it ( 'retains a recent workspace and reports a failed removal' , async ( ) => {
329+ vi . mocked ( globalAPI . getRecentWorkspaces ) . mockResolvedValue ( [ recentWorkspace ( 'one' ) ] ) ;
330+ vi . mocked ( globalAPI . removeRecentWorkspace ) . mockRejectedValue ( new Error ( 'Host offline' ) ) ;
331+ await render ( { onPickRemoteFolder : vi . fn ( ) } ) ;
332+ await act ( async ( ) => document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · one"]' ) ! . click ( ) ) ;
333+ expect ( document . querySelector ( '[data-workspace-choice="one"]' ) ) . not . toBeNull ( ) ;
334+ expect ( document . querySelector ( '[role="alert"]' ) ?. textContent ) . toContain ( 'Host offline' ) ;
335+ } ) ;
336+
337+ it ( 'ignores a recent workspace removal response after switching devices' , async ( ) => {
338+ vi . mocked ( globalAPI . getRecentWorkspaces ) . mockResolvedValue ( [ recentWorkspace ( 'one' ) ] ) ;
339+ let finish ! : ( ) => void ;
340+ vi . mocked ( globalAPI . removeRecentWorkspace ) . mockReturnValue ( new Promise ( resolve => { finish = resolve ; } ) ) ;
341+ await render ( { onPickRemoteFolder : vi . fn ( ) } ) ;
342+ await act ( async ( ) => document . querySelector < HTMLButtonElement > ( 'button[aria-label="actions.delete · one"]' ) ! . click ( ) ) ;
343+ act ( ( ) => activateSurface ( surfaceIdForDevice ( 'peer' ) ) ) ;
344+ await act ( async ( ) => finish ( ) ) ;
345+ expect ( globalAPI . removeRecentWorkspace ) . toHaveBeenCalledTimes ( 1 ) ;
346+ expect ( document . querySelector ( '[data-workspace-choice="one"]' ) ) . not . toBeNull ( ) ;
347+ expect ( document . querySelector ( '[role="alert"]' ) ) . toBeNull ( ) ;
348+ } ) ;
349+
263350 it ( 'does not repeat the device name below the current-computer header' , async ( ) => {
264351 await render ( { onPickRemoteFolder : vi . fn ( ) } ) ;
265352 const row = document . querySelectorAll ( '[data-openbitfun-part="sourceField"]' ) [ 0 ] ;
0 commit comments