Skip to content

fix(push): Drop the URL field from push before pushing fails - #3603

Open
nickvergessen wants to merge 1 commit into
masterfrom
bugfix/3598/trim-forever
Open

fix(push): Drop the URL field from push before pushing fails#3603
nickvergessen wants to merge 1 commit into
masterfrom
bugfix/3598/trim-forever

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Nov 15, 2026

Copy link
Copy Markdown
Member

Assisted-by: ClaudeCode:claude-opus-5-5

Fix #3598

@nickvergessen nickvergessen added this to the Nextcloud 36 milestone Nov 15, 2026
@nickvergessen nickvergessen self-assigned this Nov 15, 2026
@nickvergessen
nickvergessen force-pushed the bugfix/3598/trim-forever branch from 311f60c to b630a28 Compare November 15, 2026 13:51
@github-actions

github-actions Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9653 was 9158 (+5.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
nickvergessen force-pushed the bugfix/3598/trim-forever branch from b630a28 to c03fbab Compare November 15, 2026 13:54
@github-actions

github-actions Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9653 was 9158 (+5.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen

nickvergessen commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@nickvergessen

nickvergessen commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@nickvergessen

nickvergessen commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@nickvergessen
fix(push): Drop the URL field from push before pushing fails
eab04db 
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen force-pushed the bugfix/3598/trim-forever branch from c03fbab to eab04db Compare November 15, 2026 14:08
@github-actions

github-actions Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9654 was 9158 (+5.41%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@mafel786 mafel786 mentioned this pull request Nov 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudormant sudormant Awaiting requested review from sudormant

At least 1 approving review is required to merge this pull request.

Assignees

@nickvergessen nickvergessen

Labels

3. to review backport-request bug feature: push 📲

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

Proxy push loops forever (100% CPU) when the payload exceeds 200 bytes without the subject

1 participant

@nickvergessen