From 48107b92de425494d4737da099aaa980f6b705a4 Mon Sep 17 00:00:00 2001
From: jay23606 <jay.abdal@outlook.com>
Date: Mon, 9 Nov 2026 14:27:05 -0500
Subject: [PATCH] fix(settings): bind settings dialog open state with v-model
 for Vue 3

Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
---
 src/components/Modals/SettingsDialog.vue |  2 +-
 tests/check_settings_dialog_model.py     | 26 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 tests/check_settings_dialog_model.py

diff --git a/src/components/Modals/SettingsDialog.vue b/src/components/Modals/SettingsDialog.vue
index 3a354ed97..6eca6fd31 100644
--- a/src/components/Modals/SettingsDialog.vue
+++ b/src/components/Modals/SettingsDialog.vue
@@ -6,7 +6,7 @@ SPDX-License-Identifier: AGPL-3.0-only OR AGPL-3.0-or-later
 
 <template>
     <NcAppSettingsDialog
-        :open.sync="isOpen"
+        v-model:open="isOpen"
         :name="t('cookbook', 'Cookbook settings')"
         :show-navigation="true"
         first-selected-section="keyboard shortcuts"
diff --git a/tests/check_settings_dialog_model.py b/tests/check_settings_dialog_model.py
new file mode 100644
index 000000000..a58af8122
--- /dev/null
+++ b/tests/check_settings_dialog_model.py
@@ -0,0 +1,26 @@
+# SPDX-FileCopyrightText: 2026 Nextcloud cookbook contributors
+#
+# SPDX-License-Identifier: AGPL-3.0-only OR AGPL-3.0-or-later
+
+"""Check that SettingsDialog binds NcAppSettingsDialog's open state with Vue 3 syntax."""
+
+import sys
+from pathlib import Path
+
+path = Path(__file__).resolve().parent.parent / "src" / "components" / "Modals" / "SettingsDialog.vue"
+text = path.read_text(encoding="utf-8")
+
+if ":open.sync" in text:
+    print("FAIL: SettingsDialog.vue uses ':open.sync', which Vue 3 ignores; expected 'v-model:open'")
+    sys.exit(1)
+
+if 'v-model:open="isOpen"' not in text:
+    print("FAIL: SettingsDialog.vue does not bind 'v-model:open=\"isOpen\"'")
+    sys.exit(1)
+
+dialog = Path(__file__).resolve().parent.parent / "node_modules" / "@nextcloud" / "vue" / "dist" / "chunks" / "NcAppSettingsDialog.mjs"
+if 'emits: ["update:open"]' not in dialog.read_text(encoding="utf-8"):
+    print("FAIL: NcAppSettingsDialog does not declare the 'update:open' event that v-model:open needs")
+    sys.exit(1)
+
+print("OK: SettingsDialog.vue binds the open state with v-model:open")