Skip to content

fix: SEO requires description but IndexTemplate omits it #455

Description

@jimmyandrade

Summary

Opening the home page logs:

Warning: Failed prop type: The prop `description` is marked as required in `SEO`, but its value is `undefined`.
    at SEO (…/metax/dist/…)
    at SEO (src/components/SEO/index.js)
    at IndexTemplate (src/templates/index.js)

Root cause

metax SEO marks description as required. IndexTemplate (and some other templates) pass title / titleTemplate but not description. Site metadata already has a default description in config/siteMetadata.

Acceptance criteria

Resolution

Shipped in #456 (consumer). Upstream open: muy/muy#155.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions