chore: give every coverage pragma a reason (TS6, TS5) (#140)

Author: lesnik512

pyproject.toml

@@ -123,5 +123,5 @@ markers = [
 [tool.coverage]
 run.concurrency = ["thread"]
 run.omit = ["benchmarks/*"]
-report.exclude_also = ["if typing.TYPE_CHECKING:", 'pytest\.fail\(']
+report.exclude_also = ["if typing.TYPE_CHECKING:"]
 report.fail_under = 100

src/httpware/middleware/resilience/_event_loop_guard.py

@@ -30,8 +30,5 @@ def check_event_loop(
         cached = get_loop()
         if cached is None:
             set_loop(current)
-        # pragma below: inner double-check-with-lock race arm. Reachable only when two
-        # threads pass the outer check and race for loop_lock — free-threaded CPython can
-        # reach it, but only nondeterministically, so it stays excluded from coverage.
-        elif cached is not current:  # pragma: no cover
+        elif cached is not current:
             raise RuntimeError(message_template.format(first=cached, current=current))

src/httpware/middleware/resilience/retry.py

@@ -250,8 +250,8 @@ async def __call__(self, request: httpx2.Request, next: AsyncNext) -> httpx2.Res
                 delay = self._policy.decide(attempt=attempt, request=request, exc=exc)
             await self._sleep(delay)
 
-        msg = "unreachable"  # pragma: no cover
-        raise AssertionError(msg)  # pragma: no cover
+        msg = "unreachable"  # pragma: no cover — decide() raises on the final attempt
+        raise AssertionError(msg)  # pragma: no cover — decide() raises on the final attempt
 
 
 class Retry:
@@ -291,5 +291,5 @@ def __call__(self, request: httpx2.Request, next: Next) -> httpx2.Response:  # n
                 delay = self._policy.decide(attempt=attempt, request=request, exc=exc)
             self._sleep(delay)
 
-        msg = "unreachable"  # pragma: no cover
-        raise AssertionError(msg)  # pragma: no cover
+        msg = "unreachable"  # pragma: no cover — decide() raises on the final attempt
+        raise AssertionError(msg)  # pragma: no cover — decide() raises on the final attempt

tests/test_circuit_breaker_props.py

@@ -47,7 +47,7 @@ async def test_open_circuit_never_forwards_before_reset_timeout(
     async def _ok(request: httpx2.Request) -> httpx2.Response:
         nonlocal forwarded
         forwarded += 1  # pragma: no cover — invariant: OPEN never forwards, so this never runs
-        return httpx2.Response(200, request=request)  # pragma: no cover
+        return httpx2.Response(200, request=request)  # pragma: no cover — invariant: OPEN never forwards
 
     async def _five_hundred(request: httpx2.Request) -> httpx2.Response:
         raise InternalServerError(httpx2.Response(500, request=request))

tests/test_client_construction.py

@@ -59,10 +59,10 @@ def test_default_decoders_includes_pydantic_when_installed() -> None:
 
 def test_explicit_decoders_is_honored() -> None:
     class _Stub:
-        def can_decode(self, model: type) -> bool:  # noqa: ARG002  # pragma: no cover
+        def can_decode(self, model: type) -> bool:  # noqa: ARG002  # pragma: no cover — never invoked; the test only checks the stored decoders tuple
             return True
 
-        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover
+        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover — never invoked; the test only checks the stored decoders tuple
             return None
 
     stub = _Stub()
@@ -78,7 +78,7 @@ def test_empty_decoders_is_honored() -> None:
 async def test_missing_decoder_raised_before_http_call() -> None:
     """response_model with no claiming decoder raises before the transport is invoked."""
 
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked when MissingDecoderError fires")
 
     transport = httpx2.MockTransport(handler)
@@ -114,7 +114,7 @@ def test_explicit_middleware_is_honored() -> None:
     captured: list[str] = []
 
     class _Tag:
-        async def __call__(self, request, next) -> httpx2.Response:  # noqa: A002, ANN001  # pragma: no cover
+        async def __call__(self, request, next) -> httpx2.Response:  # noqa: A002, ANN001  # pragma: no cover — never invoked; the test only checks the stored middleware tuple
             captured.append("tag")
             return await next(request)
 

tests/test_client_decoders_default.py

@@ -47,10 +47,10 @@ def test_async_empty_explicit_decoders() -> None:
 
 def test_async_explicit_decoders_skip_default_probe() -> None:
     class _Custom:
-        def can_decode(self, model: type) -> bool:  # noqa: ARG002  # pragma: no cover
+        def can_decode(self, model: type) -> bool:  # noqa: ARG002  # pragma: no cover — never invoked; the test only checks the stored decoders tuple
             return True
 
-        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover
+        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover — never invoked; the test only checks the stored decoders tuple
             return None
 
     custom = _Custom()

tests/test_client_dispatch.py

@@ -138,7 +138,7 @@ async def test_async_list_of_basemodel_routes_to_pydantic() -> None:
 async def test_async_missing_decoder_with_empty_list() -> None:
     """Empty decoder list and response_model= raises before HTTP call."""
 
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked")
 
     transport = httpx2.MockTransport(handler)
@@ -158,10 +158,10 @@ class _Stub:
         def can_decode(self, model: type) -> bool:  # noqa: ARG002
             return False
 
-        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover
+        def decode(self, content: bytes, model: type) -> object:  # noqa: ARG002  # pragma: no cover — never invoked; can_decode() rejects every model
             return None
 
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked")
 
     transport = httpx2.MockTransport(handler)
@@ -244,7 +244,7 @@ def test_sync_list_of_basemodel_routes_to_pydantic() -> None:
 
 
 def test_sync_missing_decoder_with_empty_list() -> None:
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked")
 
     transport = httpx2.MockTransport(handler)
@@ -260,7 +260,7 @@ def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
 async def test_async_msgspec_only_list_of_basemodel_preflight_raises() -> None:
     """MsgspecDecoder-only client raises MissingDecoderError for list[BaseModel] without sending a request."""
 
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked: pre-flight must reject first")
 
     transport = httpx2.MockTransport(handler)
@@ -276,7 +276,7 @@ def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
 def test_sync_msgspec_only_list_of_basemodel_preflight_raises() -> None:
     """Sync MsgspecDecoder-only client raises MissingDecoderError for list[BaseModel] without sending a request."""
 
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked: pre-flight must reject first")
 
     transport = httpx2.MockTransport(handler)

tests/test_client_per_verb_with_response.py

@@ -73,7 +73,7 @@ async def test_with_response_decode_failure_raises_decode_error() -> None:
 
 
 async def test_with_response_missing_decoder_before_http_call() -> None:
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked when MissingDecoderError fires")
 
     client = AsyncClient(httpx2_client=httpx2.AsyncClient(transport=httpx2.MockTransport(handler)), decoders=[])

tests/test_client_per_verb_with_response_sync.py

@@ -73,7 +73,7 @@ def test_with_response_decode_failure_raises_decode_error() -> None:
 
 
 def test_with_response_missing_decoder_before_http_call() -> None:
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked when MissingDecoderError fires")
 
     client = Client(httpx2_client=httpx2.Client(transport=httpx2.MockTransport(handler)), decoders=[])

tests/test_client_send_with_response.py

@@ -131,7 +131,7 @@ def handler(request: httpx2.Request) -> httpx2.Response:
 
 
 async def test_send_with_response_raises_missing_decoder_before_http_call() -> None:
-    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover
+    def handler(_: httpx2.Request) -> httpx2.Response:  # pragma: no cover — never invoked; decoder check fails first
         pytest.fail("transport should not be invoked when MissingDecoderError fires")
 
     transport = httpx2.MockTransport(handler)