Skip to content

Commit e3aafef

Browse files
authored
docs: record the drive-qualified bind as settled, not open (#136)
ADR-0006 called the drive-qualified bind "what remains open" and cited #111, which had already closed as working as intended: the long form reaches the capability, and refusing the short spelling is the better tool on Linux, where it almost always means a drive that is not there. The conformance summary pointed readers at "the open limitation issues", of which there are now none. It names the two ADRs that hold the rulings instead.
1 parent d52e93f commit e3aafef

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

‎docs/adr/0006-docker-rejection-parity.md‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,14 @@ rule allows. The price is the reason the issue stayed open rather than something
6868
service's typo now refuses the file for every target in it. Both documents moved out of a residual
6969
catalogue and into `tests/conformance/corpus/`, where `assert_rule` -- which raises on exactly that
7070
combination -- is what holds them closed, so the rule is hard everywhere with nothing suspended.
71-
What remains open is a limitation rather than a residual: the drive-qualified *bind*
72-
(`C:\data:/var`), since podman mounts that source through `--mount` and only the short `-v` spec
73-
cannot spell it -- the long form already emits `--mount`, so the capability is reachable today and
74-
only the short spelling is missing
75-
([#111](https://github.com/modern-python/compose2pod/issues/111)).
71+
One over-rejection is settled rather than open: the drive-qualified *bind* (`C:\data:/var`).
72+
podman mounts that source through `--mount` and only the short `-v` spec cannot spell it, so the
73+
capability is reachable today -- the long form emits exactly the invocation measured at exit 0,
74+
and a `LIMITATIONS` row asserts it continuously. What was left was the ergonomic question, and
75+
[#111](https://github.com/modern-python/compose2pod/issues/111) closed it as working as intended:
76+
on Linux that spelling overwhelmingly means a Windows user pointed at a drive that is
77+
not there, and falling back to `--mount` would bind a relative directory literally named
78+
`C:\data`, surfacing much later as an empty mount instead of at once as an error naming the long
79+
form. So the refusal is the tool, not a gap waiting to be filled. What would reopen it is a real
80+
document wanting a colon in a short-form bind source on Linux, which is the evidence
81+
[#86](https://github.com/modern-python/compose2pod/issues/86) never had.

‎tests/conformance/conftest.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ def pytest_terminal_summary(terminalreporter: pytest.TerminalReporter) -> None:
6565
terminalreporter.write_line(label)
6666
terminalreporter.write_line(
6767
f"{len(over_rejections)} over-rejection(s) -- catalogued limitations, not failures; "
68-
"cross-check against the open limitation issues"
68+
"each is ruled on in docs/adr/0003-the-shared-namespace-decides-key-classification.md "
69+
"or docs/adr/0006-docker-rejection-parity.md, and one with no ruling there is the thing "
70+
"to chase"
6971
)
7072

7173

0 commit comments

Comments
 (0)