Skip to content

Zip files with same Relative File Path but different Aliases are combined across Installers #660

Description

@Trenly

Brief description of your issue

The latest manifest for Microsoft.DSC has an x64 portable zip installer and an arm64 portable zip installer. Both reference the same relative file path for the executable, but the portable command alias is different. When running wingetcreate update the entries get combined causing validation to fail

... (x64)
  NestedInstallerFiles:
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dsc
... (arm64)
  NestedInstallerFiles:
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dscarm64

Result after wingetcreate update:

... (x64)
  NestedInstallerFiles:
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dsc
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dscarm64
... (arm64)
  NestedInstallerFiles:
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dsc
  - RelativeFilePath: dsc.exe
    PortableCommandAlias: dscarm64

Steps to reproduce

wingetcreate update Microsoft.DSC --version 3.2.0 --urls 'https://github.com/PowerShell/DSC/releases/download/v3.2.0/DSC-3.2.0-x86_64-pc-windows-msvc.zip' 'https://github.com/PowerShell/DSC/releases/download/v3.2.0/DSC-3.2.0-aarch64-pc-windows-msvc.zip' 'https://github.com/PowerShell/DSC/releases/download/v3.2.0/DSC-3.2.0-Win.msixbundle'

Expected behavior

Entries would be preserved per installer node

Actual behavior

Entries are combined

Environment

Windows Package Manager Manifest Creator v1.12.8.0
Copyright (c) Microsoft Corporation. All rights reserved.

Operating System: Microsoft Windows NT 10.0.26200.0
System Architecture: X64

Winget-Create Directories  Path                                                                                                           
------------------------------------------------------------------------------------------------------------------------------------------
Logs                       %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\DiagOutputDir  
User settings              %LOCALAPPDATA%\Packages\Microsoft.WindowsPackageManagerManifestCreator_8wekyb3d8bbwe\LocalState\settings.json  
Installer cache            %TEMP%\wingetcreate

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions