Copyright Attribution and License Issues

[ma-ilsi]

There are two issues with regards to copyright license and attribution in the (otherwise very organized) Rababa repository.

Firstly: M. A. H. Madhfar's copyright attribution and his MIT license are missing. Please have a look at his license below:

https://github.com/almodhfer/Arabic_Diacritization/tree/main

It is on the main branch, while the rest of his work is on the master branch.

Secondly, I believe the repository is missing the GPLV2 and copyright attribution for the tashkeela dataset that is in the repo, currently. You can even just hyperlink to the dataset instead of including it within the repo.

[ronaldtse]

@ma-ilsi — Thank you for raising this. Both attribution gaps have now been addressed:

1. Main rababa repo — closed via fix: update copyright, license and attribution, fixes #46 #47 (M. A. H. Madhfar MIT license, Taha Zerrouki + Hamza Abbad attribution, GPLv2 note for Tashkeela).

2. rababa-tashkeela data repo — opened docs: explicit GPLv2 license + author attribution rababa-tashkeela#1 to mirror the same explicit GPLv2 license + author attributions for the Tashkeela dataset redistribution.

Appreciate the report — it prompted us to audit both repos for consistency.