Found by the master fix round on #211 (merged fb1861405), named rather than smuggled into that PR because repairing it means reformatting 44 files unrelated to ADR-065.
The defect
.github/workflows/ci.yml, Check code formatting: the step's retry loop breaks on the first red attempt and prints "skipped", then exits 0. So the formatting gate reports success no matter what the tree looks like — a guard that prints but does not stop is decorative.
Measured: 44 files currently do not comply, the same 44 before and after that PR's changes, and none of them are the regenerated AuthZEN files. So the debt is pre-existing and the gate has been inert for some time.
Suggested fix, in two steps so neither is a big-bang
- Reformat the 44 files in a standalone PR that touches nothing else, so the diff is reviewable as pure formatting.
- Then repair the step so a non-zero result actually fails the job, and confirm by planting one badly-formatted file and observing the job go red.
Doing (2) before (1) turns the next unrelated PR red for reasons its author did not cause.
Related
Sibling CI-integrity gaps found in the same review round: axonflow-sdk-rust declares zero required status checks (its whole board is advisory), and axonflow-sdk-typescript's ruleset requires only two contexts, so its generated-types currency gate is bypassable. Both are ruleset settings for the operator.
Found by the master fix round on #211 (merged
fb1861405), named rather than smuggled into that PR because repairing it means reformatting 44 files unrelated to ADR-065.The defect
.github/workflows/ci.yml,Check code formatting: the step's retry loop breaks on the first red attempt and prints "skipped", then exits 0. So the formatting gate reports success no matter what the tree looks like — a guard that prints but does not stop is decorative.Measured: 44 files currently do not comply, the same 44 before and after that PR's changes, and none of them are the regenerated AuthZEN files. So the debt is pre-existing and the gate has been inert for some time.
Suggested fix, in two steps so neither is a big-bang
Doing (2) before (1) turns the next unrelated PR red for reasons its author did not cause.
Related
Sibling CI-integrity gaps found in the same review round:
axonflow-sdk-rustdeclares zero required status checks (its whole board is advisory), andaxonflow-sdk-typescript's ruleset requires only two contexts, so its generated-types currency gate is bypassable. Both are ruleset settings for the operator.