Skip to content

Commit 08f5f6b

Browse files
committed
Revert "gh: drop Codecov token, upload works without one for fork PRs"
This reverts commit 87deb87. Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
1 parent 87deb87 commit 08f5f6b

2 files changed

Lines changed: 14 additions & 21 deletions

File tree

‎.github/workflows/linux_tests.yaml‎

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,9 @@ jobs:
6767
- name: Uninstall Modules
6868
run: |
6969
make uninstall
70-
# no token needed: public repo uses Codecov's tokenless upload via
71-
# GitHub OIDC, which also works for pull requests coming from forks
72-
# (base repo secrets are never exposed to fork-triggered PR runs)
7370
- uses: codecov/codecov-action@v7
71+
with:
72+
token: ${{ secrets.CODECOV_TOKEN }}
7473
- uses: actions/upload-artifact@v7
7574
if: failure()
7675
with:
@@ -155,10 +154,9 @@ jobs:
155154
- name: Uninstall Modules
156155
run: |
157156
make uninstall
158-
# no token needed: public repo uses Codecov's tokenless upload via
159-
# GitHub OIDC, which also works for pull requests coming from forks
160-
# (base repo secrets are never exposed to fork-triggered PR runs)
161157
- uses: codecov/codecov-action@v7
158+
with:
159+
token: ${{ secrets.CODECOV_TOKEN }}
162160
- uses: actions/upload-artifact@v7
163161
if: failure()
164162
with:
@@ -239,10 +237,9 @@ jobs:
239237
- name: Uninstall Modules
240238
run: |
241239
make uninstall
242-
# no token needed: public repo uses Codecov's tokenless upload via
243-
# GitHub OIDC, which also works for pull requests coming from forks
244-
# (base repo secrets are never exposed to fork-triggered PR runs)
245240
- uses: codecov/codecov-action@v7
241+
with:
242+
token: ${{ secrets.CODECOV_TOKEN }}
246243
- uses: actions/upload-artifact@v7
247244
if: failure()
248245
with:
@@ -308,10 +305,9 @@ jobs:
308305
- name: Uninstall Modules
309306
run: |
310307
make uninstall
311-
# no token needed: public repo uses Codecov's tokenless upload via
312-
# GitHub OIDC, which also works for pull requests coming from forks
313-
# (base repo secrets are never exposed to fork-triggered PR runs)
314308
- uses: codecov/codecov-action@v7
309+
with:
310+
token: ${{ secrets.CODECOV_TOKEN }}
315311
- uses: actions/upload-artifact@v7
316312
if: failure()
317313
with:
@@ -379,10 +375,9 @@ jobs:
379375
- name: Uninstall Modules
380376
run: |
381377
make uninstall
382-
# no token needed: public repo uses Codecov's tokenless upload via
383-
# GitHub OIDC, which also works for pull requests coming from forks
384-
# (base repo secrets are never exposed to fork-triggered PR runs)
385378
- uses: codecov/codecov-action@v7
379+
with:
380+
token: ${{ secrets.CODECOV_TOKEN }}
386381
- uses: actions/upload-artifact@v7
387382
if: failure()
388383
with:
@@ -525,10 +520,9 @@ jobs:
525520
- name: Uninstall Modules
526521
run: |
527522
make uninstall
528-
# no token needed: public repo uses Codecov's tokenless upload via
529-
# GitHub OIDC, which also works for pull requests coming from forks
530-
# (base repo secrets are never exposed to fork-triggered PR runs)
531523
- uses: codecov/codecov-action@v7
524+
with:
525+
token: ${{ secrets.CODECOV_TOKEN }}
532526
- uses: actions/upload-artifact@v7
533527
if: failure()
534528
with:

‎.github/workflows/macos_tests.yaml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,9 @@ jobs:
6262
- name: Uninstall Modules
6363
run: |
6464
make uninstall
65-
# no token needed: public repo uses Codecov's tokenless upload via
66-
# GitHub OIDC, which also works for pull requests coming from forks
67-
# (base repo secrets are never exposed to fork-triggered PR runs)
6865
- uses: codecov/codecov-action@v7
66+
with:
67+
token: ${{ secrets.CODECOV_TOKEN }}
6968
- uses: actions/upload-artifact@v7
7069
if: failure()
7170
with:

0 commit comments

Comments
 (0)