Repository navigation
chore(ci): push tags with a release GitHub App token - #41
Merged
Merged
Conversation
dnlopes
changed the title
github-actions
Bot
added
patch
Contributor
Trivy Security Scan ResultsNote This PR introduces no new findings. Scan performed by Trivy v0.69.3 |
|
🎉 This PR is included in version 7.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mints a GitHub App token in the release workflow and uses it for every tag-writing path, so an org ruleset can block
v*tag creation for everyone except the app.Do not merge before the org variable
RELEASE_APP_IDand the org secretRELEASE_APP_PRIVATE_KEYexist. Until then the token step fails and releases fail.Changes in
.github/workflows/release.yaml:actions/create-github-app-token(pinned to a commit SHA, v3.3.0) withapp-id: ${{ vars.RELEASE_APP_ID }}andprivate-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}.actions/checkoutso persisted git credentials push with the app identity.GITHUB_TOKENto semantic-release.permissions:are unchanged. The app needs contents, issues, and pull requests write access to match what semantic-release does.Not changed:
sync-vendored-skills.yamlpushessync/*branches and opens PRs. It writes no tags or releases, so it keeps the built-in token.dependabot-merge.yamlcalls the reusable workflowdavidnlopes/Reusable.Workflows/.github/workflows/dependabot-merge.yaml@v1. I did not inspect it. It looks like a merge workflow, not a tag writer, but confirm in that repository.Verification:
actionlintis not installed here, so I did not run it. I checked the YAML diff by hand.