Skip to content

Editor syntax-highlight colours are raw hex and not theme-aware #490

Description

@dubadub

Found during review of #456.

static/js/src/editor.js (around lines 95–103) defines the Cooklang highlight colours as hex literals (#8b5cf6, #6366f1, #9ca3af, #d97706, …). They do not flip with the theme, so some read poorly on the dark editor surface, and they are the last non-token colours in the UI. The CodeMirror chrome (gutters, caret, selection) already resolves through tokens in static/css/input.css.

Fix: emit the highlight styles as CSS classes and colour them from tokens (add a small --syntax-* set to input.css), or read the custom properties at editor init.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions