Parley: no regex split in the compiled server, guide prose, a sturdier admin menu pick

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: shai-almog

docs/developer-guide/Parley-Implementors-Guide.asciidoc

@@ -2,7 +2,7 @@
 == Parley: Building on the sample
 
 Parley is a messenger, and most of what makes one isn't in the server. The
-server stores and relays envelopes it can't open; the keys, the sessions, the
+server stores and relays ciphertext it can't open; the keys, the sessions, the
 encryption and the history are in the app. Parley kept what it shares with
 <<wayline-implementors-guide,Wayline>> and <<savor-implementors-guide,Savor>>: the
 module layout, the accounts and sign-in, text messages, push notifications, the
@@ -188,8 +188,8 @@ the user's guide says so.
 === Calls
 
 A call is two apps and a relay. The server never touches the media: it rings the
-callee, relays the signalling, and hands out the addresses of the servers the apps
-use to reach each other. The media itself is WebRTC's, encrypted with DTLS-SRTP
+callee, relays the signalling, and hands out the addresses of the servers through which
+the apps reach each other. The media itself is WebRTC's, encrypted with DTLS-SRTP
 between the two devices.
 
 The app owns the signalling, which is how `com.codename1.webrtc` is meant to be used
@@ -247,8 +247,8 @@ include::../demos/common/src/main/snippets/developer-guide/parley.sh[tag=parley-
 
 `parley.ice.secret` is the secret shared with the TURN server -- coturn's
 `static-auth-secret`, with `use-auth-secret` on. `Calls.ice` builds the credential
-the way coturn checks it: the user name is the expiry time and the account, and the
-password is the HMAC-SHA1 of the user name under the secret. Nothing is stored, and
+the way coturn checks it: the username is the expiry time and the account, and the
+password is the HMAC-SHA1 of the username under the secret. Nothing is stored, and
 a leaked credential stops working on its own after `parley.ice.ttl` seconds. With
 no TURN server set, only STUN is handed out, and calls between networks that block
 a direct path fail. The default STUN server is a public one; run your own for a
@@ -275,7 +275,7 @@ include::../demos/common/src/main/snippets/developer-guide/parley.sh[tag=parley-
   `/bridge/whatsapp`, answers the verify token when subscribing, and signs every
   delivery with the app secret, which the server checks.
 
-image::img/parley-bot-chat.png["A chat with the demo bot under a banner that says its messages are not end-to-end encrypted",scaledwidth=40%]
+image::img/parley-bot-chat.png["A chat with the demo bot under a banner that says its messages aren't end-to-end encrypted",scaledwidth=40%]
 
 ==== The privacy trade-off
 

docs/developer-guide/Parley-Users-Guide.asciidoc

@@ -121,7 +121,7 @@ There are three kinds of conversation:
 |===
 
 The button on the chat list starts a conversation: find a person by name,
-username or phone number, make a group, or join one with an invite link.
+username or phone number, make a group, or join one with an invitation link.
 
 A conversation shows its messages as they arrive, a typing indicator, and the
 state of each message you sent: sent, delivered, and read. A message can be

docs/developer-guide/languagetool-accept.txt

@@ -809,3 +809,10 @@ inlined
 Parley
 Savor
 Wayline
+prekey
+prekeys
+rekey
+callee
+signalling
+coturn
+unconfigured

scripts/initializr/common/src/main/resources/parley-modules.zip

@@ -321,11 +321,19 @@ private void replay(CallRecord row) {
             return;
         }
         live.toDevice(row.getCalleeDevice(), replayed(row, OFFER, setup.getOffer()));
-        String[] each = setup.getCandidates().split("\n");
-        for (int iter = 0; iter < each.length; iter++) {
-            if (each[iter].length() > 0) {
-                live.toDevice(row.getCalleeDevice(), replayed(row, ICE, each[iter]));
+        // One candidate a line. Walked by hand: the compiled backend has no
+        // String.split, which is a regular expression.
+        String all = setup.getCandidates();
+        int start = 0;
+        while (start < all.length()) {
+            int end = all.indexOf('\n', start);
+            if (end < 0) {
+                end = all.length();
+            }
+            if (end > start) {
+                live.toDevice(row.getCalleeDevice(), replayed(row, ICE, all.substring(start, end)));
             }
+            start = end + 1;
         }
         setups.deleteById(row.getId());
     }

scripts/parley/backend/src/main/java/com/codenameone/examples/parley/call/Calls.java

@@ -342,9 +342,24 @@ try {
     return seeded.some(name => text.includes(name));
   });
   // The admin's menu ends with the console, after Settings.
-  await overflowCommand(4);
-  await waitFor('the admin console', stepSeconds, async () =>
-      /Messages\s+today/.test(await screenText()));
+  // The menu's rows are clicked where they are drawn, and on a slow runner the
+  // popup can still be sliding in when the click lands: a click that missed
+  // leaves the chats list up, so the menu is opened and picked again.
+  for (let attempt = 1; ; attempt++) {
+    await overflowCommand(4);
+    try {
+      await waitFor('the admin console', attempt < 3 ? 15 : stepSeconds, async () =>
+          /Messages\s+today/.test(await screenText()));
+      break;
+    } catch (e) {
+      if (attempt >= 3 || problems.length > 0) {
+        throw e;
+      }
+      say('the admin console did not open; picking it from the menu again');
+      await page.keyboard.press('Escape');
+      await settled();
+    }
+  }
   await waitFor('the console to ask the server for its figures', stepSeconds, async () =>
       requests.some(r => /^200 GET \/api\/admin\//.test(r)));
   await page.waitForTimeout(3000);