You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When someone wants the avro format to create or read events, they add this module and they concern about potential conflicts with pre-existing dependencies in their projects.
@slinkydeveloper: I do have implementation of EventFormat interface for avro. However, the implementation class has a setter method for Avro schema since this not defined in EventFormat interface. Hence, following code would be used to get hold of format and serialize.
The schema at https://github.com/cloudevents/spec/blob/v1.0/spec.avsc is just a spec, whereas real schema would have much more details (in data part, with specific field definitions).
Hence loading statically as resource won't work. More often, these spec compliant schemas are stored at third-party registries.
TBH I'm not an expert of avro, so I can't tell. What I can say is that it sounds weird to me to mutate the internal state of EventFormat in order to provide a custom schema... My expectation is that EventFormat doesn't parse the body, but it just collects it in a raw form (like in json, where it collects the data as json node) and then the user process this raw data into the pojo she/he wants to.
I think you should check out this PR where they're working on improving the schema cloudevents/spec#613
@subanasifhttps://github.com/cloudevents/spec/blob/v1.0/spec.avsc is compiled into Java before shipping, so dynamically loading it is not necessary (although possible). That Avro spec is used by other CE clients, so I don't think it can be changed as long as compatibility with CE 1.0 is desired.
@subanasifhttps://github.com/cloudevents/spec/blob/v1.0/spec.avsc is compiled into Java before shipping, so dynamically loading it is not necessary (although possible). That Avro spec is used by other CE clients, so I don't think it can be changed as long as compatibility with CE 1.0 is desired.
I'm not sure that's what is being suggested. @subanasif you mentioned you had an implementation, any chance you could share it for some more context?
Activity
subanasif commentedon Dec 11, 2020
@slinkydeveloper: I do have implementation of EventFormat interface for avro. However, the implementation class has a setter method for Avro schema since this not defined in EventFormat interface. Hence, following code would be used to get hold of format and serialize.
Let me know your thoughts.
slinkydeveloper commentedon Dec 11, 2020
Which schema?
subanasif commentedon Dec 11, 2020
This is avro schema. That is
org.apache.avro.Schema.This could be coming from filesystem or remote repository like schema registry.
slinkydeveloper commentedon Dec 11, 2020
avro schema of what? of Cloudevents? The one from the spec https://github.com/cloudevents/spec/blob/v1.0/spec.avsc?
subanasif commentedon Dec 11, 2020
Thats correct. It *.avsc schema
slinkydeveloper commentedon Dec 11, 2020
Shouldn't this be loaded statically? Can we ship this schema as a resource in the package and then load it statically?
subanasif commentedon Dec 11, 2020
The schema at https://github.com/cloudevents/spec/blob/v1.0/spec.avsc is just a spec, whereas real schema would have much more details (in
datapart, with specific field definitions).Hence loading statically as resource won't work. More often, these spec compliant schemas are stored at third-party registries.
slinkydeveloper commentedon Dec 11, 2020
TBH I'm not an expert of avro, so I can't tell. What I can say is that it sounds weird to me to mutate the internal state of
EventFormatin order to provide a custom schema... My expectation is that EventFormat doesn't parse the body, but it just collects it in a raw form (like in json, where it collects the data as json node) and then the user process this raw data into the pojo she/he wants to.I think you should check out this PR where they're working on improving the schema cloudevents/spec#613
yuce commentedon Dec 11, 2020
@subanasif https://github.com/cloudevents/spec/blob/v1.0/spec.avsc is compiled into Java before shipping, so dynamically loading it is not necessary (although possible). That Avro spec is used by other CE clients, so I don't think it can be changed as long as compatibility with CE 1.0 is desired.
pdebuitlear commentedon Jan 24, 2021
I'm not sure that's what is being suggested.
@subanasif you mentioned you had an implementation, any chance you could share it for some more context?
pdebuitlear commentedon Apr 18, 2021
any update on this issue?
alsonlu commentedon Jun 28, 2021
Is there any update on if/when this will be released?
slinkydeveloper commentedon Jun 29, 2021
This is just waiting for a contribution to come 😄
sunng87 commentedon Jul 16, 2021
Just let you know I have been working on an avro serde impl these days.