Skip to content

Follow-up: remaining paper-* token gaps after #367/#373 #380

Description

@chiptus

PR #373 (issue #367) moved role tokens (background, foreground, muted-foreground, ring, border) from .edition-view-scoped to global :root, and introduced a paper-* token family as a stopgap for light/white admin and shared shadcn chrome. Branch claude/implement-367-zrn4kp has the latest work (rebased onto current main after #373 merged), including a fix already pushed there for the Textarea focus ring and Tabs active state.

Remaining items surfaced during PR #373 review:

Needs a real fix (architectural)

  • MarkdownText renders white-on-white in admin. src/pages/admin/ArtistsManagement/BulkEditor/TextareaCell.tsx renders populated artist descriptions through src/components/ui/markdown-text.tsx, whose prose-headings:text-foreground/prose-p:text-foreground/prose-code:text-foreground classes now resolve to white (the global --foreground). On the white admin card this text is unreadable. Can't just swap to paper-* globally — MarkdownText is also used on dark edition-view surfaces (SetInfoCard, IndividualArtistCard, SetDescription, InfoText, etc.) where text-foreground (white) is correct. Needs a variant/prop so the component can pick paper-* vs. default tokens by context.

Needs a small fix (missing border-paper-border)

Same root cause as the fixed items below — these paper-surfaced components still use an unqualified border, which resolves to the global translucent purple --border instead of the intended paper border:

  • src/components/ui/alert-dialog.tsx:37AlertDialogContent's border needs border-paper-border alongside it.
  • src/components/ui/alert.tsx:11 — the default Alert variant needs border-paper-border added.
  • src/components/ui/toast.tsx:30 — the default Radix toast variant needs border-paper-border added.

Already fixed (no action needed, listed for completeness)

  • Toast ToastClose white-on-white — fixed via paper-foreground.
  • Textarea focus ring (ring-ringring-paper-ring) and Tabs active state (bg-background/text-foregroundpaper-*) — fixed on branch claude/implement-367-zrn4kp (commit def1d36).

Branch

All follow-up work should build on claude/implement-367-zrn4kp, which is rebased onto current main.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions