test NavigationManager.NavigateTo(external url)

[TDroogers]

Is it possible to test a NavigateTo an external url?

The following code works in production. NavigationManager.NavigateTo("https://example.com");

However when running in bUnit it throws the error: The URI 'https://example.com' is not contained by the base URI 'http://localhost/'.

[egil]

Hi @TDroogers,

Can you share the full stack trace. It seems this might be a bug in bUnits fake navigation manager. I think you should be able to navigate to an external URL.

[linkdotnet]

I reproduced the issue with the following stack trace:

   at Microsoft.AspNetCore.Components.NavigationManager.Validate(Uri baseUri, String uri)
   at Microsoft.AspNetCore.Components.NavigationManager.set_Uri(String value)
   at Bunit.TestDoubles.FakeNavigationManager.NavigateToCore(String uri, NavigationOptions options) in C:\Users\stgi\source\repos\bUnit\src\bunit.web\TestDoubles\NavigationManager\FakeNavigationManager.cs:line 53
   at Microsoft.AspNetCore.Components.NavigationManager.NavigateToCore(String uri, Boolean forceLoad)
   at Microsoft.AspNetCore.Components.NavigationManager.NavigateTo(String uri, Boolean forceLoad, Boolean replace)

The reason is this line which leads to validate the new uri vs the BaseUri. Neither the RemoteNavigationManager nor WebAssemblyNavigationManager does set the Uri - property at all on NavigateToCore. Both do it via JS-Interop. Simple fix would be to use the backing field instead of the property. From an API point of view everything would work as expected and we would fix this issue.

[linkdotnet]

If you think this is a viable approach I can take the lead on this one @egil

[egil]

As far as I can tell, RemoteNavigationManager does set the Uri property, it just does it indirectly through JavaScript as you say, so if it is internal site/page links, then the Uri property does get set. If it is external links, then the apps JavaScript obviously doesn't run, so it doesn't set the Url, because the user navigated to an external page.

So, in a way, NavigationManager simply doesn't support this particular use case, because it is designed to not see external URLs.

What I think we might need to do is to detect when NavigateTo gets called with an absolute URL that is different from that of the BaseUrl property, and then first set BaseUrl to that of the new url's domain part. That will prevent the exception when the Url property is set.

This should be safe since existing tests in the wild would not have worked if they had this behaviour.

[TDroogers]

It looks like the same issue as @linkdotnet found.

   at Microsoft.AspNetCore.Components.NavigationManager.Validate(Uri baseUri, String uri)
   at Microsoft.AspNetCore.Components.NavigationManager.set_Uri(String value)
   at Bunit.TestDoubles.FakeNavigationManager.NavigateToCore(String uri, NavigationOptions options) in /_/src/bunit.web/TestDoubles/NavigationManager/FakeNavigationManager.cs:line 53
   at Microsoft.AspNetCore.Components.NavigationManager.NavigateToCore(String uri, Boolean forceLoad)
   at Microsoft.AspNetCore.Components.NavigationManager.NavigateTo(String uri, Boolean forceLoad, Boolean replace)
   at PubbleCloud.Frontend.Client.Pages.Authentication.Login.ValueChanged(Object sender, FieldChangedEventArgs e) in D:\Source\Repos\PubbleCloud.Frontend\PubbleCloud.Frontend\Client\Pages\Authentication\Login.razor.cs:line 57

[egil]

@TDroogers, Steven has fixed this and there should be a nightly release coming to GitHub Package Repository soon. Thanks for bringing this to our attention.

[TDroogers]

Thank you!