From ce906354602dcea38005339086dbe143280440ec Mon Sep 17 00:00:00 2001 From: dawidkwiecien Date: Sat, 11 Jul 2026 10:55:11 +0200 Subject: [PATCH 1/4] Fix AassertTrue/assertFalse simplified regarding the report from sonarQube --- .../samplers/TestSampleSaveConfiguration.java | 78 +++++++++--------- .../jorphan/collections/PackageTest.java | 80 ++++++++----------- 2 files changed, 71 insertions(+), 87 deletions(-) diff --git a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java index 0735445a2ff..2fdbd8ce310 100644 --- a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java +++ b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java @@ -17,12 +17,6 @@ package org.apache.jmeter.samplers; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertNotSame; -import static org.junit.jupiter.api.Assertions.assertTrue; - import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; @@ -30,6 +24,8 @@ import org.apache.jmeter.junit.JMeterTestCase; import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.*; + // Extends JMeterTest case because it needs access to JMeter properties public class TestSampleSaveConfiguration extends JMeterTestCase { @@ -50,21 +46,21 @@ public void testClone() throws Exception { SampleSaveConfiguration cloneA = (SampleSaveConfiguration) a.clone(); assertNotSame(a, cloneA); assertEquals(a, cloneA); - assertTrue(a.equals(cloneA)); - assertTrue(cloneA.equals(a)); + assertEquals(a, cloneA); + assertEquals(cloneA, a); assertEquals(a.hashCode(), cloneA.hashCode()); // Change the original a.setUrl(true); - assertFalse(a.equals(cloneA)); - assertFalse(cloneA.equals(a)); - assertFalse(a.hashCode() == cloneA.hashCode()); + assertNotEquals(a, cloneA); + assertNotEquals(cloneA, a); + assertNotEquals(a.hashCode(), cloneA.hashCode()); // Change the original back again a.setUrl(false); assertEquals(a, cloneA); - assertTrue(a.equals(cloneA)); - assertTrue(cloneA.equals(a)); + assertEquals(a, cloneA); + assertEquals(cloneA, a); assertEquals(a.hashCode(), cloneA.hashCode()); } @@ -85,8 +81,8 @@ public void testEqualsAndHashCode() throws Exception { // a and b should be equal assertEquals(a, b); - assertTrue(a.equals(b)); - assertTrue(b.equals(a)); + assertEquals(a, b); + assertEquals(b, a); assertEquals(a.hashCode(), b.hashCode()); assertPrimitiveEquals(a.saveUrl(), b.saveUrl()); assertPrimitiveEquals(a.saveAssertions(), b.saveAssertions()); @@ -95,10 +91,10 @@ public void testEqualsAndHashCode() throws Exception { a.setAssertions(false); // a and b should not be equal - assertFalse(a.equals(b)); - assertFalse(b.equals(a)); - assertFalse(a.hashCode() == b.hashCode()); - assertFalse(a.saveAssertions() == b.saveAssertions()); + assertNotEquals(a, b); + assertNotEquals(b, a); + assertNotEquals(a.hashCode(), b.hashCode()); + assertNotEquals(a.saveAssertions(), b.saveAssertions()); } @Test @@ -106,8 +102,8 @@ public void testFalse() throws Exception { SampleSaveConfiguration a = new SampleSaveConfiguration(false); SampleSaveConfiguration b = new SampleSaveConfiguration(false); assertEquals(a.hashCode(), b.hashCode(), "Hash codes should be equal"); - assertTrue(a.equals(b), "Objects should be equal"); - assertTrue(b.equals(a), "Objects should be equal"); + assertEquals(a, b, "Objects should be equal"); + assertEquals(b, a, "Objects should be equal"); } @Test @@ -115,16 +111,16 @@ public void testTrue() throws Exception { SampleSaveConfiguration a = new SampleSaveConfiguration(true); SampleSaveConfiguration b = new SampleSaveConfiguration(true); assertEquals(a.hashCode(), b.hashCode(), "Hash codes should be equal"); - assertTrue(a.equals(b), "Objects should be equal"); - assertTrue(b.equals(a), "Objects should be equal"); + assertEquals(a, b, "Objects should be equal"); + assertEquals(b, a, "Objects should be equal"); } @Test public void testFalseTrue() throws Exception { SampleSaveConfiguration a = new SampleSaveConfiguration(false); SampleSaveConfiguration b = new SampleSaveConfiguration(true); - assertFalse(a.hashCode() == b.hashCode(), "Hash codes should not be equal"); - assertFalse(a.equals(b), "Objects should not be equal"); - assertFalse(b.equals(a), "Objects should not be equal"); + assertNotEquals(a.hashCode(), b.hashCode(), "Hash codes should not be equal"); + assertNotEquals(a, b, "Objects should not be equal"); + assertNotEquals(b, a, "Objects should not be equal"); } @Test @@ -132,27 +128,27 @@ public void testFormatter() throws Exception { SampleSaveConfiguration a = new SampleSaveConfiguration(false); SampleSaveConfiguration b = new SampleSaveConfiguration(false); assertEquals(a.hashCode(), b.hashCode(), "Hash codes should be equal"); - assertTrue(a.equals(b), "Objects should be equal"); - assertTrue(b.equals(a), "Objects should be equal"); - assertTrue(a.strictDateFormatter() == null); - assertTrue(b.strictDateFormatter() == null); - assertTrue(a.threadSafeLenientFormatter() == null); - assertTrue(b.threadSafeLenientFormatter() == null); + assertEquals(a, b, "Objects should be equal"); + assertEquals(b, a, "Objects should be equal"); + assertNull(a.strictDateFormatter()); + assertNull(b.strictDateFormatter()); + assertNull(a.threadSafeLenientFormatter()); + assertNull(b.threadSafeLenientFormatter()); a.setDateFormat(null); b.setDateFormat(null); assertEquals(a.hashCode(), b.hashCode(), "Hash codes should be equal"); - assertTrue(a.equals(b), "Objects should be equal"); - assertTrue(b.equals(a), "Objects should be equal"); - assertTrue(a.strictDateFormatter() == null); - assertTrue(b.strictDateFormatter() == null); - assertTrue(a.threadSafeLenientFormatter() == null); - assertTrue(b.threadSafeLenientFormatter() == null); + assertEquals(a, b, "Objects should be equal"); + assertEquals(b, a, "Objects should be equal"); + assertNull(a.strictDateFormatter()); + assertNull(b.strictDateFormatter()); + assertNull(a.threadSafeLenientFormatter()); + assertNull(b.threadSafeLenientFormatter()); a.setDateFormat("dd/MM/yyyy"); b.setDateFormat("dd/MM/yyyy"); assertEquals(a.hashCode(), b.hashCode(), "Hash codes should be equal"); - assertTrue(a.equals(b), "Objects should be equal"); - assertTrue(b.equals(a), "Objects should be equal"); - assertTrue(a.strictDateFormatter().equals(b.strictDateFormatter()), "Objects should be equal"); + assertEquals(a, b, "Objects should be equal"); + assertEquals(b, a, "Objects should be equal"); + assertEquals(a.strictDateFormatter(), b.strictDateFormatter(), "Objects should be equal"); } @Test diff --git a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java index 5aa3c4b0987..29b7704eed2 100644 --- a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java +++ b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java @@ -17,12 +17,6 @@ package org.apache.jorphan.collections; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertNotSame; -import static org.junit.jupiter.api.Assertions.assertTrue; - import java.util.Arrays; import java.util.Collection; @@ -30,6 +24,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import static org.junit.jupiter.api.Assertions.*; + public class PackageTest { private static Logger log = LoggerFactory.getLogger(PackageTest.class); @@ -52,16 +48,12 @@ public void testEqualsAndHashCode1() throws Exception { HashTree tree3 = new HashTree("abcde"); HashTree tree4 = new HashTree("abcde"); - assertTrue(tree1.equals(tree1)); - assertTrue(tree1.equals(tree2)); - assertTrue(tree2.equals(tree1)); - assertTrue(tree2.equals(tree2)); + assertEquals(tree1, tree2); + assertEquals(tree2, tree1); assertEquals(tree1.hashCode(), tree2.hashCode()); - assertTrue(tree3.equals(tree3)); - assertTrue(tree3.equals(tree4)); - assertTrue(tree4.equals(tree3)); - assertTrue(tree4.equals(tree4)); + assertEquals(tree3, tree4); + assertEquals(tree4, tree3); assertEquals(tree3.hashCode(), tree4.hashCode()); assertNotSame(tree1, tree2); @@ -70,24 +62,24 @@ public void testEqualsAndHashCode1() throws Exception { assertNotSame(tree2, tree3); assertNotSame(tree2, tree4); - assertFalse(tree1.equals(tree3)); - assertFalse(tree1.equals(tree4)); - assertFalse(tree2.equals(tree3)); - assertFalse(tree2.equals(tree4)); + assertNotEquals(tree1, tree3); + assertNotEquals(tree1, tree4); + assertNotEquals(tree2, tree3); + assertNotEquals(tree2, tree4); assertNotNull(tree1); assertNotNull(tree2); tree1.add("abcd", tree3); - assertFalse(tree1.equals(tree2)); - assertFalse(tree2.equals(tree1));// Check reflexive + assertNotEquals(tree1, tree2); + assertNotEquals(tree2, tree1);// Check reflexive if (tree1.hashCode() == tree2.hashCode()) { // This is not a requirement System.out.println("WARN: unequal HashTrees should not have equal hashCodes"); } tree2.add("abcd", tree4); - assertTrue(tree1.equals(tree2)); - assertTrue(tree2.equals(tree1)); + assertEquals(tree1, tree2); + assertEquals(tree2, tree1); assertEquals(tree1.hashCode(), tree2.hashCode()); } @@ -112,37 +104,33 @@ public void testEqualsAndHashCode2() throws Exception { ListedHashTree tree3 = new ListedHashTree("abcde"); ListedHashTree tree4 = new ListedHashTree("abcde"); - assertTrue(tree1.equals(tree1)); - assertTrue(tree1.equals(tree2)); - assertTrue(tree2.equals(tree1)); - assertTrue(tree2.equals(tree2)); + assertEquals(tree1, tree2); + assertEquals(tree2, tree1); assertEquals(tree1.hashCode(), tree2.hashCode()); - assertTrue(tree3.equals(tree3)); - assertTrue(tree3.equals(tree4)); - assertTrue(tree4.equals(tree3)); - assertTrue(tree4.equals(tree4)); + assertEquals(tree3, tree4); + assertEquals(tree4, tree3); assertEquals(tree3.hashCode(), tree4.hashCode()); assertNotSame(tree1, tree2); assertNotSame(tree1, tree3); - assertFalse(tree1.equals(tree3)); - assertFalse(tree3.equals(tree1)); - assertFalse(tree1.equals(tree4)); - assertFalse(tree4.equals(tree1)); + assertNotEquals(tree1, tree3); + assertNotEquals(tree3, tree1); + assertNotEquals(tree1, tree4); + assertNotEquals(tree4, tree1); - assertFalse(tree2.equals(tree3)); - assertFalse(tree3.equals(tree2)); - assertFalse(tree2.equals(tree4)); - assertFalse(tree4.equals(tree2)); + assertNotEquals(tree2, tree3); + assertNotEquals(tree3, tree2); + assertNotEquals(tree2, tree4); + assertNotEquals(tree4, tree2); tree1.add("abcd", tree3); - assertFalse(tree1.equals(tree2)); - assertFalse(tree2.equals(tree1)); + assertNotEquals(tree1, tree2); + assertNotEquals(tree2, tree1); tree2.add("abcd", tree4); - assertTrue(tree1.equals(tree2)); - assertTrue(tree2.equals(tree1)); + assertEquals(tree1, tree2); + assertEquals(tree2, tree1); assertEquals(tree1.hashCode(), tree2.hashCode()); tree1.add("a1"); @@ -150,16 +138,16 @@ public void testEqualsAndHashCode2() throws Exception { tree2.add("a2"); tree2.add("a1"); - assertFalse(tree1.equals(tree2)); - assertFalse(tree2.equals(tree1)); + assertNotEquals(tree1, tree2); + assertNotEquals(tree2, tree1); if (tree1.hashCode() == tree2.hashCode()) { // This is not a requirement System.out.println("WARN: unequal ListedHashTrees should not have equal hashcodes"); } tree4.add("abcdef"); - assertFalse(tree3.equals(tree4)); - assertFalse(tree4.equals(tree3)); + assertNotEquals(tree3, tree4); + assertNotEquals(tree4, tree3); } @Test From f7506257f431d61178b61dfbdd58d1357b5b6132 Mon Sep 17 00:00:00 2001 From: dawidkwiecien Date: Sun, 12 Jul 2026 00:25:49 +0200 Subject: [PATCH 2/4] Fixed order of imports --- .../apache/jmeter/samplers/TestSampleSaveConfiguration.java | 4 ++-- .../test/java/org/apache/jorphan/collections/PackageTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java index 2fdbd8ce310..acb3878ab43 100644 --- a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java +++ b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java @@ -17,6 +17,8 @@ package org.apache.jmeter.samplers; +import static org.junit.jupiter.api.Assertions.*; + import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; @@ -24,8 +26,6 @@ import org.apache.jmeter.junit.JMeterTestCase; import org.junit.jupiter.api.Test; -import static org.junit.jupiter.api.Assertions.*; - // Extends JMeterTest case because it needs access to JMeter properties public class TestSampleSaveConfiguration extends JMeterTestCase { diff --git a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java index 29b7704eed2..951db55ef2d 100644 --- a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java +++ b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java @@ -17,6 +17,8 @@ package org.apache.jorphan.collections; +import static org.junit.jupiter.api.Assertions.*; + import java.util.Arrays; import java.util.Collection; @@ -24,8 +26,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.junit.jupiter.api.Assertions.*; - public class PackageTest { private static Logger log = LoggerFactory.getLogger(PackageTest.class); From eafbf46a2f89fbd6ce27b4e8de4d2b6103cfced1 Mon Sep 17 00:00:00 2001 From: dawidkwiecien Date: Sun, 12 Jul 2026 13:10:00 +0200 Subject: [PATCH 3/4] Fixed to not import with .* --- .../jmeter/samplers/TestSampleSaveConfiguration.java | 8 +++++++- .../java/org/apache/jorphan/collections/PackageTest.java | 5 ++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java index acb3878ab43..60b21c5e8cb 100644 --- a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java +++ b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java @@ -17,7 +17,13 @@ package org.apache.jmeter.samplers; -import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNotSame; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.assertNotEquals; +import static org.junit.jupiter.api.Assertions.assertNull; import java.lang.reflect.Method; import java.util.ArrayList; diff --git a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java index 951db55ef2d..3ca37093e1b 100644 --- a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java +++ b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java @@ -17,7 +17,10 @@ package org.apache.jorphan.collections; -import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNotSame; +import static org.junit.jupiter.api.Assertions.assertNotEquals; import java.util.Arrays; import java.util.Collection; From 905cbb33c925f8ad46e568478c02ad4656c42655 Mon Sep 17 00:00:00 2001 From: dawidkwiecien Date: Sun, 12 Jul 2026 13:22:11 +0200 Subject: [PATCH 4/4] Format files with ./gradlew autostyleApply --- .../apache/jmeter/samplers/TestSampleSaveConfiguration.java | 4 ++-- .../test/java/org/apache/jorphan/collections/PackageTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java index 60b21c5e8cb..b2a33686810 100644 --- a/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java +++ b/src/core/src/test/java/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java @@ -19,11 +19,11 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotSame; -import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.lang.reflect.Method; import java.util.ArrayList; diff --git a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java index 3ca37093e1b..64a91e32f2a 100644 --- a/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java +++ b/src/jorphan/src/test/java/org/apache/jorphan/collections/PackageTest.java @@ -18,9 +18,9 @@ package org.apache.jorphan.collections; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotSame; -import static org.junit.jupiter.api.Assertions.assertNotEquals; import java.util.Arrays; import java.util.Collection;