Skip to content

Fix CI build warnings #322

Closed
Closed

Description

@wgtmac

There are a lot of CI warnings that are worth fixing. For example: https://github.com/apache/iceberg-cpp/actions/runs/19386197700/job/55473420291?pr=320

Activity

  1. changed the title [-]Fix build warnings[/-] [+]Fix CI build warnings[/+] on Nov 15, 2025
  2. Jinchul81 commented on Nov 19, 2025

    @Jinchul81

    I am interested in this work as a newcomer. May I provide a PR?

  3. Fokko commented on Nov 19, 2025

    @Fokko
    Contributor

    @Jinchul81 Go ahead, first come, first serve :)

  4. Jinchul81 commented on Nov 19, 2025

    @Jinchul81

    Please review the PR #328

  5. Joe-Abraham commented on Mar 8, 2026

    @Joe-Abraham

    I've created a PR to resolve the build warnings reported here. The fixes have been split into logical commits to make the review process easier:

    1. Fixed unused parameter warnings: Added [[maybe_unused]] where appropriate.
    2. Fixed uninitialized member warnings: Added default initializers to struct and class members.
    3. Fixed integer sign comparison warnings: Used <utility> functions like std::cmp_equal, std::cmp_less.
    4. Fixed various other build warnings: Addressed specific operator precedence warnings and redundant std::move calls.
    5. Cleaned up shadowing warnings/unused functions: Renamed shadowed arguments and removed unused local test helpers.

    PR Link - #587

    @Fokko @wgtmac could some one help review and merge

  6. added 2 commits that reference this issue on Nov 1, 2026
    180f0bf
    3ba2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions