fix(meson): use system OpenSSL for bundled SDK on Linux

Author: zhjwpku

README.md

@@ -123,6 +123,7 @@ Arrow, Avro, CRoaring, and sqlpp23 source fallbacks use upstream CMake. Use
 
 Enable S3 with `-Ds3=enabled`. System Arrow must include S3 support; the Arrow
 source fallback bundles AWS SDK by default.
+On Linux, the bundled SDK uses system OpenSSL for s2n TLS support.
 Use `-Dbundle_awssdk=false` to use an installed AWS SDK in the Arrow source build.
 When S3 bundles AWS SDK, `-Dsigv4=enabled` reuses it for REST authentication;
 SigV4 without S3 requires an installed AWS SDK.

mkdocs/docs/getting-started.md

@@ -100,6 +100,7 @@ Arrow, Avro, CRoaring, and sqlpp23 source fallbacks use upstream CMake. Use
 
 Enable S3 with `-Ds3=enabled`. System Arrow must include S3 support; the Arrow
 source fallback bundles AWS SDK by default.
+On Linux, the bundled SDK uses system OpenSSL for s2n TLS support.
 Use `-Dbundle_awssdk=false` to use an installed AWS SDK in the Arrow source build.
 When S3 bundles AWS SDK, `-Dsigv4=enabled` reuses it for REST authentication;
 SigV4 without S3 requires an installed AWS SDK.

subprojects/packagefiles/arrow/CMakeLists.txt

@@ -48,6 +48,22 @@ if(NOT DEFINED ENV{ARROW_THRIFT_URL})
   set(ENV{ARROW_THRIFT_URL}
       "https://archive.apache.org/dist/thrift/0.22.0/thrift-0.22.0.tar.gz")
 endif()
+
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux"
+   AND ARROW_S3
+   AND AWSSDK_SOURCE STREQUAL "BUNDLED")
+  # Meson cannot translate s2n's libcrypto symbol rewriting commands. Use the
+  # same system OpenSSL as Arrow and aws-c-cal instead of embedding AWS-LC.
+  set(FETCHCONTENT_SOURCE_DIR_AWS-LC "${CMAKE_CURRENT_LIST_DIR}/openssl")
+  include(FetchContent)
+  macro(FetchContent_MakeAvailable)
+    if("${ARGV0}" STREQUAL "s2n-tls")
+      set(S2N_INTERN_LIBCRYPTO OFF)
+      set(ADDITIONAL_FLAGS "-DCOMPILE_DEFINITIONS=-I${OPENSSL_INCLUDE_DIR}")
+    endif()
+    _fetchcontent_makeavailable(${ARGV})
+  endmacro()
+endif()
 add_subdirectory("${CMAKE_CURRENT_LIST_DIR}/cpp" upstream)
 
 # Meson needs compile flags to recognize PIC on archives of object libraries.

subprojects/packagefiles/arrow/openssl/CMakeLists.txt

@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+cmake_minimum_required(VERSION 3.25)
+
+# Provide s2n's expected target without introducing a second libcrypto.
+find_package(OpenSSL REQUIRED GLOBAL)
+add_library(crypto INTERFACE IMPORTED GLOBAL)
+target_link_libraries(crypto INTERFACE OpenSSL::Crypto)