Skip to content

Commit 97ce6eb

Browse files
authored
fix: correct mismatched class and struct declarations (#911)
Keep Projections and TableMetadataBuilder::Impl declarations consistent with their definitions to avoid mismatched-tag diagnostics and potential link failures under the Microsoft C++ ABI.
1 parent dcf92f5 commit 97ce6eb

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/iceberg/expression/projections.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class ICEBERG_EXPORT ProjectionEvaluator {
4343
Result<std::shared_ptr<Expression>> Project(const std::shared_ptr<Expression>& expr);
4444

4545
private:
46-
friend class Projections;
46+
friend struct Projections;
4747

4848
/// \brief Create a ProjectionEvaluator.
4949
///

‎src/iceberg/table_metadata.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ class ICEBERG_EXPORT TableMetadataBuilder : public ErrorCollector {
489489
explicit TableMetadataBuilder(const TableMetadata* base);
490490

491491
/// Internal state members
492-
struct Impl;
492+
class Impl;
493493
std::unique_ptr<Impl> impl_;
494494
};
495495

0 commit comments

Comments
 (0)