Skip to content

Commit 41ff77e

Browse files
fix(io): rethrow exceptions from S3 delete helpers
wait() leaves an exception stored in a helper's future, so a delete that threw was neither counted nor reported, and DeleteFiles could return success. get() rethrows it on the calling thread, as the sequential loop did.
1 parent 4341a22 commit 41ff77e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎src/iceberg/arrow/s3/arrow_s3_file_io.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ Status ArrowS3FileIO::DeleteFiles(const std::vector<std::string>& file_locations
318318
}
319319
delete_remaining();
320320
for (auto& helper : helpers) {
321-
helper.wait();
321+
helper.get(); // Rethrows what a helper threw.
322322
}
323323
if (failed > 0) {
324324
return IOError("Failed to delete {} of {} files", failed.load(),

0 commit comments

Comments
 (0)