fix: release candidate version string

Author: zhjwpku

CMakeLists.txt

@@ -28,8 +28,7 @@ project(Iceberg
         DESCRIPTION "Iceberg C++ Project"
         LANGUAGES CXX)
 
-set(ICEBERG_VERSION_SUFFIX "-SNAPSHOT")
-set(ICEBERG_VERSION_STRING "${PROJECT_VERSION}${ICEBERG_VERSION_SUFFIX}")
+set(ICEBERG_VERSION_STRING "${PROJECT_VERSION}")
 configure_file("${CMAKE_CURRENT_SOURCE_DIR}/src/iceberg/version.h.in"
                "${CMAKE_BINARY_DIR}/src/iceberg/version.h")
 

dev/release/verify_rc.sh

@@ -124,6 +124,16 @@ test_source_distribution() {
     -DICEBERG_BUILD_SHARED=ON \
     --compile-no-warning-as-error
 
+  version_header="build/src/iceberg/version.h"
+  if ! grep -Fq "#define ICEBERG_VERSION_STRING \"${VERSION}\"" "${version_header}"; then
+    echo "Unexpected ICEBERG_VERSION_STRING in ${version_header}; expected ${VERSION}."
+    exit 1
+  fi
+  if grep -Fq "SNAPSHOT" "${version_header}"; then
+    echo "Release candidate version must not contain SNAPSHOT."
+    exit 1
+  fi
+
   # Build
   cmake --build build --parallel $(nproc || sysctl -n hw.ncpu || echo 4)
 

src/iceberg/meson.build

@@ -29,6 +29,7 @@ conf_data.set('PROJECT_VERSION_MAJOR', ver_major)
 conf_data.set('PROJECT_VERSION_MINOR', ver_minor)
 conf_data.set('PROJECT_VERSION_PATCH', ver_patch)
 conf_data.set('PROJECT_VERSION', version)
+conf_data.set('ICEBERG_VERSION_STRING', version)
 conf_data.set('PROJECT_NAME', meson.project_name())
 configure_file(
     input: 'version.h.in',