address review

Author: HuaHuaY

.pre-commit-config.yaml

@@ -33,7 +33,7 @@ repos:
         exclude: ^src/iceberg/catalog/hive/gen-cpp/
 
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v22.1.5
+    rev: v20.1.8
     hooks:
       - id: clang-format
         exclude_types: [json]

src/iceberg/manifest/manifest_group.cc

@@ -43,7 +43,7 @@
 #include "iceberg/type.h"
 #include "iceberg/util/checked_cast.h"
 #include "iceberg/util/content_file_util.h"
-#include "iceberg/util/executor_util.h"
+#include "iceberg/util/executor_util_internal.h"
 #include "iceberg/util/macros.h"
 
 namespace iceberg {

src/iceberg/test/executor_util_test.cc

@@ -17,8 +17,6 @@
  * under the License.
  */
 
-#include "iceberg/util/executor_util.h"
-
 #include <atomic>
 #include <concepts>
 #include <functional>
@@ -37,6 +35,7 @@
 #include "iceberg/result.h"
 #include "iceberg/test/executor.h"
 #include "iceberg/test/matchers.h"
+#include "iceberg/util/executor_util_internal.h"
 
 namespace iceberg {
 
@@ -171,37 +170,6 @@ TEST(ParallelCollectTest, CollectsMultipleRanges) {
   EXPECT_EQ(executor.submit_count(), 4);
 }
 
-namespace {
-struct CustomValues {
-  std::vector<int> values;
-};
-}  // namespace
-
-template <>
-struct ParallelReduce<CustomValues> {
-  using result_type = CustomValues;
-
-  template <std::ranges::input_range Values>
-  static result_type Reduce(Values&& values) {
-    result_type result;
-    for (const auto& value : values) {
-      result.values.insert(result.values.end(), value.values.begin(), value.values.end());
-    }
-    return result;
-  }
-};
-
-TEST(ParallelCollectTest, CollectsCustomContainer) {
-  std::vector<int> input = {1, 2, 3};
-
-  auto result = ParallelCollect(std::nullopt, input, [](int value) {
-    return Result<CustomValues>{CustomValues{{value, value * 10}}};
-  });
-
-  EXPECT_THAT(result, IsOk());
-  EXPECT_THAT(result->values, ElementsAre(1, 10, 2, 20, 3, 30));
-}
-
 TEST(ParallelCollectTest, PropagatesTaskErrors) {
   std::vector<int> input = {1, 2, 3};
   std::atomic<int> calls = 0;