Cover public usage response network routing

Author: PrashantBhanage

server/src/test/java/com/cloud/api/ApiResponseHelperTest.java

@@ -1480,6 +1480,51 @@ public void createUsageResponseDispatchesAllUsageTypes(int usageType) {
         }
     }
 
+    @Test
+    @DisplayName("createUsageResponse preserves non-public network details")
+    public void createUsageResponsePreservesNonPublicNetworkDetails() {
+        UsageVO usageRecord = mock(UsageVO.class);
+        Account account = mock(Account.class);
+        DomainVO domain = new DomainVO();
+        NetworkVO network = mock(NetworkVO.class);
+
+        when(usageRecord.getAccountId()).thenReturn(1L);
+        when(usageRecord.getUsageType()).thenReturn(UsageTypes.NETWORK_BYTES_SENT);
+        when(usageRecord.getType()).thenReturn("UserVm");
+        when(usageRecord.getUsageId()).thenReturn(14L);
+        when(usageRecord.getNetworkId()).thenReturn(24L);
+        when(usageRecord.getRawUsage()).thenReturn(1024D);
+        when(usageRecord.getVmInstanceId()).thenReturn(null);
+        when(usageRecord.getVmName()).thenReturn("vm");
+        when(usageRecord.getTemplateId()).thenReturn(null);
+        when(usageRecord.getOfferingId()).thenReturn(null);
+
+        when(account.getType()).thenReturn(Account.Type.NORMAL);
+        when(account.getUuid()).thenReturn("account-uuid");
+        when(account.getAccountName()).thenReturn("account");
+        when(account.getDomainId()).thenReturn(2L);
+        domain.setId(2L);
+        domain.setUuid("domain-uuid");
+        domain.setName("domain");
+        domain.setPath("/domain/");
+
+        when(entityManagerMock.findByIdIncludingRemoved(NetworkVO.class, 24L)).thenReturn(network);
+        when(network.getId()).thenReturn(24L);
+        when(network.getUuid()).thenReturn("network-uuid");
+        when(network.getName()).thenReturn("guest-network");
+        when(network.getTrafficType()).thenReturn(Networks.TrafficType.Guest);
+
+        try (MockedStatic<ApiDBUtils> ignored = Mockito.mockStatic(ApiDBUtils.class)) {
+            when(ApiDBUtils.findAccountById(1L)).thenReturn(account);
+            when(ApiDBUtils.findDomainById(2L)).thenReturn(domain);
+
+            UsageRecordResponse response = helper.createUsageResponse(usageRecord, null, false);
+
+            assertResponseField(response, "networkId", "network-uuid");
+            assertResponseField(response, "resourceName", "guest-network");
+        }
+    }
+
     private Object invokeUsageDetailsHelper(String methodName, Class<?>[] parameterTypes, Object... args) throws Exception {
         Method method = ApiResponseHelper.class.getDeclaredMethod(methodName, parameterTypes);
         method.setAccessible(true);