Skip to content

Commit 33ac0b8

Browse files
committed
Add unit tests
1 parent 83b11f1 commit 33ac0b8

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

‎plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.junit.runner.RunWith;
2626
import org.mockito.InjectMocks;
2727
import org.mockito.MockedConstruction;
28+
import org.mockito.MockedStatic;
2829
import org.mockito.Mockito;
2930
import org.mockito.Spy;
3031
import org.mockito.junit.MockitoJUnitRunner;
@@ -138,4 +139,27 @@ public void deleteBrRemovesTheBridgeCreatedForVlan() throws InternalErrorExcepti
138139
Assert.assertEquals("breth1-100", createdBridge);
139140
Mockito.verify(driver).deleteVnetBr(createdBridge, true);
140141
}
142+
143+
private Script deleteVxlanBridge(String vxlanPif) {
144+
Mockito.doReturn(vxlanPif).when(driver).getVxlanPif("5000");
145+
try (MockedStatic<Script> script = Mockito.mockStatic(Script.class);
146+
MockedConstruction<Script> commands = Mockito.mockConstruction(Script.class)) {
147+
script.when(() -> Script.runSimpleBashScript("ls /sys/class/net/brvx-5000")).thenReturn("brif");
148+
script.when(() -> Script.runSimpleBashScript("ls /sys/class/net/brvx-5000/brif | tr '\n' ' '")).thenReturn("vxlan5000 ");
149+
driver.deleteVnetBr("brvx-5000", true);
150+
return commands.constructed().get(0);
151+
}
152+
}
153+
154+
@Test
155+
public void deleteVnetBrPassesThePifFromTheVxlanDevice() {
156+
Script command = deleteVxlanBridge("eth0");
157+
Mockito.verify(command).add("-p", "eth0");
158+
}
159+
160+
@Test
161+
public void deleteVnetBrKeepsTheParsedPifWhenTheVxlanDeviceHasNone() {
162+
Script command = deleteVxlanBridge(null);
163+
Mockito.verify(command).add("-p", "vx");
164+
}
141165
}

0 commit comments

Comments
 (0)