Skip to content

Commit 17f02a7

Browse files
suryag1201Gupta, Surya
authored andcommitted
[CCS-5] Volume Resize Fix for IOPS and Size (#106)
### Description On Resize Volume, the form did not show the volume’s current size and IOPS. It also used the first disk offering in the list, not the offering already attached to the volume. So the dialog often opened empty or with the wrong IOPS fields, and a resize could send the wrong values. Root cause Three UI issues in fetchData(): Size unit — the API stores size in bytes. The form label is GB. Size was never copied onto the form, so the GB field stayed empty. Wrong offering — the code always used this.offerings[0] (first offering returned by listDiskOfferings), not this.resource.diskofferingid (the volume’s offering). Custom size / custom IOPS flags could be wrong. IOPS not filled — even when min/max IOPS existed on the volume, they were not copied into form.miniops / form.maxiops. Steps to reproduce Create a volume with a custom IOPS disk offering (for example min 2000, max 5000) and a known size (for example 20 GB). Open Storage → Volumes → Resize. Check the Size (GB) field and the Min/Max IOPS fields. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): Before Fix: <img width="533" height="353" alt="image" src="https://github.com/user-attachments/assets/ccfc698e-501c-442e-a7b2-9582dc2a53ba" /> After Fix: <img width="528" height="472" alt="image" src="https://github.com/user-attachments/assets/5125bb21-9b9b-4e48-a9bc-8d5eaef07118" /> ### How Has This Been Tested? Tested with both Fix and Custom IOPS: 1- Resize Shows IOPS value for custom IOPS not for fix, along with size 2- Exact 20 GB volume → shows as 20 float 20.1 -> shows on UI as 20 #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
1 parent 510d0ec commit 17f02a7

1 file changed

Lines changed: 15 additions & 8 deletions

File tree

‎ui/src/views/storage/ResizeVolume.vue‎

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ export default {
8383
},
8484
data () {
8585
return {
86-
offerings: [],
87-
customDiskOffering: false,
8886
loading: false,
8987
customDiskOfferingIops: false
9088
}
@@ -105,14 +103,23 @@ export default {
105103
},
106104
fetchData () {
107105
this.loading = true
106+
if (this.resource.size != null) {
107+
this.form.size = this.resource.size / (1024 * 1024 * 1024)
108+
}
109+
if (!this.resource.diskofferingid) {
110+
this.loading = false
111+
return
112+
}
108113
getAPI('listDiskOfferings', {
109-
zoneid: this.resource.zoneid,
110-
listall: true
114+
id: this.resource.diskofferingid,
115+
state: 'all'
111116
}).then(json => {
112-
this.offerings = json.listdiskofferingsresponse.diskoffering || []
113-
this.form.diskofferingid = this.offerings[0].id || ''
114-
this.customDiskOffering = this.offerings[0].iscustomized || false
115-
this.customDiskOfferingIops = this.offerings[0].iscustomizediops || false
117+
const currentOffering = (json.listdiskofferingsresponse.diskoffering || [])[0]
118+
this.customDiskOfferingIops = currentOffering?.iscustomizediops || false
119+
if (this.customDiskOfferingIops) {
120+
this.form.miniops = this.resource.miniops
121+
this.form.maxiops = this.resource.maxiops
122+
}
116123
}).finally(() => {
117124
this.loading = false
118125
})

0 commit comments

Comments
 (0)