Valent Run Command Fails on NixOS

[BeatLink]

Current Behavior

During startup valent shows

valent-runcommand-plugin:  WARNING: valent_runcommand_plugin_execute_local_command(): Failed to execute child process “sh” (No such file or directory)

Commands are unable to be run from remote devices

I think the core problem might be due to NixOS non standard directory layout. In that case, instead of hard coded references to executables, the code should using /usr/bin/env

Expected Behavior

Remote devices should be able to send commands.

Desktop

Cinnamon

Other Desktop

No response

Operating System

NixOS Unstable

Installed from

Distribution Package

Version

1.0.0.alpha.47

Devices

KDE Connect (Android), Valent (Desktop Linux)

Plugins

Run Command

Logs

Mar 25 06:39:22 Odin valent[5920]: 06:39:22.6103                       GLib-GIO:    DEBUG: GSocketClient: Starting TCP connection attempt
Mar 25 06:39:22 Odin valent[5920]: 06:39:22.6712                       GLib-GIO:    DEBUG: GSocketClient: TCP connection successful
Mar 25 06:39:22 Odin valent[5920]: 06:39:22.6712                       GLib-GIO:    DEBUG: GSocketClient: Starting application layer connection
Mar 25 06:39:22 Odin valent[5920]: 06:39:22.6712                       GLib-GIO:    DEBUG: GSocketClient: Connection successful!
Mar 25 06:39:22 Odin valent[5920]: 06:39:22.7000               valent-lan-utils:    DEBUG: Accepting certificate "xxx" per successful verification
Mar 25 06:39:22 Odin valent[5920]: 06:39:22.7655               valent-lan-utils:    DEBUG: Accepting certificate "xxx" per successful verification
Mar 25 06:39:39 Odin valent[5920]: 06:39:39.2160       valent-runcommand-plugin:  WARNING: valent_runcommand_plugin_execute_local_command(): Failed to execute child process “sh” (No such fil>
Mar 25 06:39:51 Odin valent[5920]: 06:39:51.6123                        Tracker:    DEBUG: Freed 1 readonly interfaces
Mar 25 06:39:51 Odin valent[5920]: 06:39:51.6125                        Tracker:    DEBUG: Freed 1 readonly interfaces
Mar 25 06:39:51 Odin valent[5920]: 06:39:51.6129                        Tracker:    DEBUG: Freed 1 readonly interfaces

Screenshots

No response

[coreyoconnor]

Checking the code:

g_string_append_printf (args, "sh -c %s", command_quoted);

valent/src/plugins/runcommand/valent-runcommand-plugin.c

Line 134 in df82168

g_string_append_printf (args, "sh -c %s", command_quoted);

Is probably the culprit. Prefixing that with /usr/bin/env would work for NixOS. Is that universally appropriate tho?

[BeatLink]

/usr/bin/env is universally appropriate. for locating binaries on linux distros in bash scripts. Even nixos which is FHS divergent supports it so yeah.