Fix: Rename Prompt and Request labels between Controller and Prompt Sampler#466
Open
roberto3554 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The labels on the arrows between the Controller and the Prompt Sampler were swapped. Arrows labelled "Prompt" should be "Request", and vice versa, which could lead to confusion when interpreting the diagram.
Solution
Update the arrow labels between the Controller and the Prompt Sampler so that "Prompt" and "Request" are assigned to the correct directions. This aligns the diagram with the actual request flow and improves clarity.
Testing