Repository navigation
feat(frontend): add shared row virtualization (WI-2147) - #502
Conversation
|
Companion tests: https://github.com/Windshiftapp/core-tests-internal/pull/46 (overlay commit b3496acc). Production commit b3ce177 passed the complete pre-commit guard set. Final focused overlay rerun is green: 62 files / 405 tests. Combined browser rerun is still running; its result will be recorded separately. Both PRs intentionally remain draft with WI-2147 In Progress. |
|
Final combined qualification on production b3ce177 / tests overlay b3496acc: 21 browser tests passed, including setup; zero retries, zero skips. Focused frontend: 62 files / 405 tests passed. Exact browser command: E2E_KEEP_ARTIFACTS=1 ../core-tests/run-e2e.sh tests/virtual-rows.spec.ts tests/backlog-virtual-drag.spec.ts tests/collection-tree-pagination.spec.ts tests/roadmap-scheduling.spec.ts tests/support-queue.spec.ts tests/board-drag-workflow.spec.ts tests/collection-map-swimlanes.spec.ts tests/backlog-story-points-availability.spec.ts tests/collection-roadmap-sse-live.spec.tsArtifacts retained in the local core-tests |
|
Size Change: 0 B 🆕 Total Size: 0 B |
|
Reviewed the full diff. Nice piece of work: the controller/adapter split, occurrence keys, sparse pins, shared viewport registry, print mode and the anchor LRU are coherent, and What I ran locally
Findings
QualificationThe |
|
Addressed the findings in 27f3839, with regression coverage in companion tests PR #46 at b07c91fc. Responding to #502 (comment):
Validation:
|
|
Merging to main at the user’s explicit request after the review follow-up. This integration decision does not mark WI-2147 complete or claim release qualification: the outstanding performance, Safari/WebKit/accessibility and interaction-matrix items in QUALIFICATION.md remain open. Companion tests PR #46 will be merged as well. PR title corrected to satisfy the conventional-title check; no CI bypass requested. |
Summary
Status: draft / not release-qualified
WI-2147 remains In Progress. This PR does not waive attachment 916 or claim all acceptance criteria are done.
See
frontend/src/lib/virtualization/QUALIFICATION.mdfor exact commands, evidence and the blocking checklist;README.mdbeside it documents reuse.Validation
Remaining blockers
Companion private tests PR uses the same branch name and is linked below once created.