fix(governance): address review feedback

- Drop the None check on get_current_span — OTel returns INVALID_SPAN,
  never None, so the span-context validity check is sufficient.
- Reword the behavior-matrix bullet: the no-op triggers on any valid
  current span context, including a remotely propagated one, not only
  a host-opened span.
- Snapshot and restore the same private tracer-provider global in the
  test helper rather than mixing it with get_tracer_provider().
- Assert the agent span's parent off the exported ReadableSpan; the
  live Span protocol has no parent attribute, which failed mypy in CI.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: JoshParkSJ

src/uipath/runtime/governance/runtime.py

@@ -79,10 +79,11 @@ def _governance_root_span(agent_name: str, runtime_id: str) -> Iterator[None]:
 
     Behavior matrix:
 
-    - **OTel installed + host opened a parent span**: no-op — the
-      host's span already supplies the ``trace_id``, and a span
-      inserted here is dropped by host-side export filters, orphaning
-      everything below it.
+    - **OTel installed + a valid span context is already current**
+      (host-opened or remotely propagated): no-op — that context
+      already supplies the ``trace_id``, and a span inserted here is
+      dropped by host-side export filters, orphaning everything
+      below it.
     - **OTel installed + no parent span**: this becomes the root
       span of a fresh trace; everything below it shares the new
       ``trace_id``.
@@ -101,8 +102,7 @@ def _governance_root_span(agent_name: str, runtime_id: str) -> Iterator[None]:
         yield
         return
 
-    current = trace.get_current_span()
-    if current is not None and current.get_span_context().is_valid:
+    if trace.get_current_span().get_span_context().is_valid:
         yield
         return
 

tests/test_governance_runtime.py

@@ -650,38 +650,42 @@ def _recording_tracer_provider() -> Iterator[Any]:
     provider = TracerProvider()
     provider.add_span_processor(SimpleSpanProcessor(exporter))
 
-    original = trace.get_tracer_provider()
-    trace._TRACER_PROVIDER = provider  # type: ignore[attr-defined]
+    original = trace._TRACER_PROVIDER
+    trace._TRACER_PROVIDER = provider
     try:
         yield exporter
     finally:
-        trace._TRACER_PROVIDER = original  # type: ignore[attr-defined]
+        trace._TRACER_PROVIDER = original
 
 
 def _exported_names(exporter: Any) -> set[str]:
     """Return the names of every span the exporter received."""
     return {span.name for span in exporter.get_finished_spans()}
 
 
+def _exported_span(exporter: Any, name: str) -> Any:
+    """Return the single exported span with ``name``."""
+    spans = [span for span in exporter.get_finished_spans() if span.name == name]
+    assert len(spans) == 1
+    return spans[0]
+
+
 async def test_execute_opens_no_span_under_a_host_span() -> None:
     """Under a host span the wrapper stays out of the tree entirely."""
     from opentelemetry import trace
 
     class _SpanOpeningDelegate(_StubDelegate):
-        """Records the parent the agent's own span is given."""
-
-        def __init__(self) -> None:
-            super().__init__()
-            self.agent_span_parent: Any = None
+        """Opens a span the way a framework adapter would."""
 
         async def execute(self, input: Any = None, options: Any = None) -> Any:
             tracer = trace.get_tracer("test.agent")
-            with tracer.start_as_current_span("agent run") as agent_span:
-                self.agent_span_parent = agent_span.parent
+            with tracer.start_as_current_span("agent run"):
+                pass
             return await super().execute(input, options)
 
-    delegate = _SpanOpeningDelegate()
-    runtime = UiPathGovernedRuntime(delegate, PolicyIndex(), EnforcementMode.AUDIT)
+    runtime = UiPathGovernedRuntime(
+        _SpanOpeningDelegate(), PolicyIndex(), EnforcementMode.AUDIT
+    )
 
     with _recording_tracer_provider() as exporter:
         host_tracer = trace.get_tracer("test.host")
@@ -690,10 +694,11 @@ async def execute(self, input: Any = None, options: Any = None) -> Any:
             assert await runtime.execute({"x": 1}) == "result"
 
         exported = _exported_names(exporter)
+        agent_span = _exported_span(exporter, "agent run")
 
     assert "uipath.governance.run" not in exported
-    assert delegate.agent_span_parent is not None
-    assert delegate.agent_span_parent.span_id == host_span_id
+    assert agent_span.parent is not None
+    assert agent_span.parent.span_id == host_span_id
 
 
 async def test_execute_opens_a_root_span_with_no_host_span() -> None: