Skip to content

Node 8+ deprecation issues #69

Description

@nthgol

Hey there,
When deploying server code to google app engine running node LTS, I get the following few errors:

In file included from ../node_modules/nan/nan.h:194:0,
from ../include/x509.h:7,
from ../src/addon.cc:5:
 ../node_modules/nan/nan_maybe_43_inl.h: In function 'Nan::MaybeLocal<v8::Object> Nan::CloneElementAt(v8::Local<v8::Array>, uint32_t)':
 ../node_modules/nan/nan_maybe_43_inl.h:220:58: warning: 'v8::MaybeLocal<v8::Object> v8::Array::CloneElementAt(v8::Local<v8::Context>, uint32_t)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:3516): Cloning is not supported. [-Wdeprecated-declarations]
    return array->CloneElementAt(GetCurrentContext(), index);
                                                           ^
In file included from ../node_modules/nan/nan_new.h:189:0,
                  from ../node_modules/nan/nan.h:200,
                  from ../include/x509.h:7,
                  from ../src/addon.cc:5:
../node_modules/nan/nan_implementation_12_inl.h: In static member function 'static Nan::imp::FactoryBase<v8::BooleanObject>::return_t Nan::imp::Factory<v8::BooleanObject>::New(bool)':
../node_modules/nan/nan_implementation_12_inl.h:40:38: warning: 'static v8::Local<v8::Value> v8::BooleanObject::New(bool)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:4845): Pass an isolate [-Wdeprecated-declarations]
    return v8::BooleanObject::New(value).As<v8::BooleanObject>();
                                       ^
 In file included from ../include/x509.h:7:0,
                  from ../src/addon.cc:5:
 ../node_modules/nan/nan.h: In function 'bool Nan::SetAccessor(v8::Local<v8::Object>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)':
 ../node_modules/nan/nan.h:1969:16: warning: 'bool v8::Object::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:3186): Use maybe version [-Wdeprecated-declarations]
      , attribute);
                 ^
   CXX(target) Release/obj.target/x509/src/x509.o
 In file included from ../node_modules/nan/nan.h:194:0,
                  from ../include/x509.h:7,
                  from ../src/x509.cc:3:
 ../node_modules/nan/nan_maybe_43_inl.h: In function 'Nan::MaybeLocal<v8::Object> Nan::CloneElementAt(v8::Local<v8::Array>, uint32_t)':
 ../node_modules/nan/nan_maybe_43_inl.h:220:58: warning: 'v8::MaybeLocal<v8::Object> v8::Array::CloneElementAt(v8::Local<v8::Context>, uint32_t)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:3516): Cloning is not supported. [-Wdeprecated-declarations]
    return array->CloneElementAt(GetCurrentContext(), index);
                                                           ^
 In file included from ../node_modules/nan/nan_new.h:189:0,
                  from ../node_modules/nan/nan.h:200,
                  from ../include/x509.h:7,
                  from ../src/x509.cc:3:
 ../node_modules/nan/nan_implementation_12_inl.h: In static member function 'static Nan::imp::FactoryBase<v8::BooleanObject>::return_t Nan::imp::Factory<v8::BooleanObject>::New(bool)':
 ../node_modules/nan/nan_implementation_12_inl.h:40:38: warning: 'static v8::Local<v8::Value> v8::BooleanObject::New(bool)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:4845): Pass an isolate [-Wdeprecated-declarations]
    return v8::BooleanObject::New(value).As<v8::BooleanObject>();
                                       ^
 In file included from ../include/x509.h:7:0,
                  from ../src/x509.cc:3:
 ../node_modules/nan/nan.h: In function 'bool Nan::SetAccessor(v8::Local<v8::Object>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)':
 ../node_modules/nan/nan.h:1969:16: warning: 'bool v8::Object::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:3186): Use maybe version [-Wdeprecated-declarations]
      , attribute);
                 ^
 ../src/x509.cc: In function 'v8::Local<v8::Value> try_parse(const string&)':
 ../src/x509.cc:368:38: warning: value computed is not used [-Wunused-value]
      BIO_set_close(ext_bio, BIO_CLOSE);
                                       ^
 ../src/x509.cc: In function 'v8::Local<v8::Value> parse_date(ASN1_TIME*)':
 ../src/x509.cc:433:60: warning: 'v8::Local<v8::Value> v8::Object::CallAsConstructor(int, v8::Local<v8::Value>*)' is deprecated (declared at /root/.node-gyp/8.11.1/include/node/v8.h:3481): Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(DateObject->CallAsConstructor(1, args));

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions