Merge pull request #44 from Erik-White/bugfix/pixel-format-overflow

Fix potential overflow in HDR pixel formats

Author: JimBobSquarePants

src/ImageSharp.Textures/PixelFormats/Generated/D32_FLOAT_S8X24_UINT.cs

@@ -171,9 +171,8 @@ public override string ToString()
         private static ulong Pack(ref Vector2 vector)
         {
             vector = Vector2.Clamp(vector, Vector2.Zero, Vector2.One);
-            return (ulong)(
-                (uint)FloatHelper.PackFloatToFloat32(vector.X)
-                | (((uint)Math.Round(vector.Y * 255F) & 255) << 32));
+            return (ulong)FloatHelper.PackFloatToFloat32(vector.X)
+                | ((ulong)((uint)Math.Round(vector.Y * 255F) & 255) << 32);
         }
     }
 }

src/ImageSharp.Textures/PixelFormats/Generated/PixelGenerator.ignore

@@ -904,11 +904,10 @@ namespace SixLabors.ImageSharp.Textures.PixelFormats
         private static ulong Pack(ref Vector4 vector)
         {
             vector = Vector4.Clamp(vector, Vector4.Zero, Vector4.One);
-            return (ulong)(
-                (uint)FloatHelper.PackFloatToFloat16(vector.X)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.Y) << 16)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.Z) << 32)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.W) << 48));
+            return (ulong)FloatHelper.PackFloatToFloat16(vector.X)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.Y) << 16)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.Z) << 32)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.W) << 48);
         }
     }
 }
@@ -1598,9 +1597,8 @@ namespace SixLabors.ImageSharp.Textures.PixelFormats
         private static ulong Pack(ref Vector2 vector)
         {
             vector = Vector2.Clamp(vector, Vector2.Zero, Vector2.One);
-            return (ulong)(
-                (uint)FloatHelper.PackFloatToFloat32(vector.X)
-                | (((uint)Math.Round(vector.Y * 255F) & 255) << 32));
+            return (ulong)FloatHelper.PackFloatToFloat32(vector.X)
+                | ((ulong)((uint)Math.Round(vector.Y * 255F) & 255) << 32);
         }
     }
 }

src/ImageSharp.Textures/PixelFormats/Generated/Rgba64Float.cs

@@ -171,11 +171,10 @@ public override string ToString()
         private static ulong Pack(ref Vector4 vector)
         {
             vector = Vector4.Clamp(vector, Vector4.Zero, Vector4.One);
-            return (ulong)(
-                (uint)FloatHelper.PackFloatToFloat16(vector.X)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.Y) << 16)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.Z) << 32)
-                | ((uint)FloatHelper.PackFloatToFloat16(vector.W) << 48));
+            return (ulong)FloatHelper.PackFloatToFloat16(vector.X)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.Y) << 16)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.Z) << 32)
+                | ((ulong)FloatHelper.PackFloatToFloat16(vector.W) << 48);
         }
     }
 }