[Security] Harden dev console assets middleware against path traversal#7743
[Security] Harden dev console assets middleware against path traversal#7743gonzaloriestra wants to merge 1 commit into
Conversation
Hardens `devConsoleAssetsMiddleware` by implementing an `isSubpath` check to ensure requested asset paths remain within the intended `rootDirectory`, preventing path traversal vulnerabilities.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This PR addresses a potential path traversal vulnerability in the dev console assets middleware.
WHAT is this pull request doing?
It ensures that requested asset paths are contained within the expected root directory by using a subpath check.
How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 15539787141918695569 started by @gonzaloriestra