You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly, apologies for the barrage of pr's as of recent 😅 (still got a few more to go after this as well 🙏🏽), but here are the numerous changes in this pr (similar to my duckstation updates):
the license identifier has been updated to be more accurate (the existing one is "deprecated" as according to spdx).
the url in the notes property has been changed to the updated docs location.
used architecture property in pcsx2.json to make it consistent with other emulators and the dev manifest.
the pre_install script now disable checks for updates on both migrated and fresh installs. in addition, for the dev manifest, fixed an issue that stated that the settings were corrupted and needing resetting to defaults on a fresh install.
post_install has been updated to use New-Item instead of the older method.
for bin, pcsx2.json gets a shim (the dev manifest already had one)
for shortcuts, pcsx2-dev.json is renamed to match how other dev builds are named (see dolphin-dev for example).
for persist, dropped deprecated items and added cache, patches & videos (with pcsx2.json also getting: covers & gamesettings to bring it in line with the dev manifest)
checkver on pcsx2-dev.json uses the github key instead of url.
lastly autoupdate on pcsx2.json drops the extract_dir as that isn't needed.
The goal was to harmonise the two as much as possible.
The standard PCSX2 installation now supports launching the app with the pcsx2 command.
First-time setup creates the configuration needed for the initial interface and updater settings.
Bug Fixes
Startup update checks are disabled in the initial configuration.
Documentation
Updated the BIOS setup link to point to the PCSX2 documentation site.
Updated the displayed license information.
Walkthrough
The stable and development PCSX2 manifests update license and setup documentation metadata, installation configuration, download and version-check settings, executable mappings, shortcut naming, and persisted paths.
Changes
PCSX2 Scoop manifests
Layer / File(s)
Summary
Package metadata and update sources bucket/pcsx2.json, bucket/pcsx2-dev.json
Both manifests use GPL-3.0-or-later and link to the PCSX2 setup documentation. The stable manifest nests download and autoupdate settings under 64bit and removes extract_dir. The development manifest changes its GitHub releases API URL.
Setup and executable configuration bucket/pcsx2.json, bucket/pcsx2-dev.json
The install scripts disable startup update checks during migration and initialize configuration when no prior Documents directory exists. Both create an empty portable.ini; the stable manifest also maps pcsx2-qt.exe to the pcsx2 command.
Shortcut and persisted paths bucket/pcsx2.json, bucket/pcsx2-dev.json
The development shortcut label changes to “PCSX2 (Development).” The manifests add persisted paths and remove the listed paths that are no longer persisted.
Merge Risk: Moderate · up to f8dbb
New PCSX2 installs from these manifests may start with no default keyboard bindings or hotkeys because the pre-created settings file marks defaults as already initialized. A rarer migration case can also leave startup update checks enabled. Resolve the fresh-install settings initialization before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "pcsx2(-dev): Modernise manifest" names the scope (the PCSX2 stable and dev manifests) and a general goal. The changeset does update both manifests and aligns them, so the title relates to t…
Description check
The description gives a clear, itemized list of the changes. It covers the license update, the notes URL, the architecture property, the pre_install and post_install changes, bin shim, shortcut rename…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "pcsx2(-dev): Modernise manifest" names the scope (the PCSX2 stable and dev manifests) and a general goal. The changeset does update both manifests and aligns them, so the title relates to the main change. It is broad, though. It does not name the specific changes, such as the license identifier, architecture nesting, or update-check disabling. The objectives describe the PR as aiming to harmonize the two manifests, which the title reflects only loosely.
Full details: Description check
Explanation
The description gives a clear, itemized list of the changes. It covers the license update, the notes URL, the architecture property, the pre_install and post_install changes, bin shim, shortcut rename, persist changes, checkver key, and autoupdate change. It also states the goal of harmonizing the two manifests. It follows the template's required items: the contributing guide checkbox is ticked. The template's Closes/Relates to line is missing. The author's own apology and emoji text is informal but not off-topic.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 5abe4e4e-34c2-4884-b74f-820ba041ca6e
Commits
Reviewing files that changed from the base of the PR and between 59e9f4e and f8dbbd6.
Files selected for processing: 2
bucket/pcsx2-dev.json
bucket/pcsx2.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, apologies for the barrage of pr's as of recent 😅 (still got a few more to go after this as well 🙏🏽), but here are the numerous changes in this pr (similar to my duckstation updates):
licenseidentifier has been updated to be more accurate (the existing one is "deprecated" as according to spdx).notesproperty has been changed to the updated docs location.architectureproperty in pcsx2.json to make it consistent with other emulators and the dev manifest.pre_installscript now disable checks for updates on both migrated and fresh installs. in addition, for the dev manifest, fixed an issue that stated that the settings were corrupted and needing resetting to defaults on a fresh install.post_installhas been updated to use New-Item instead of the older method.bin, pcsx2.json gets a shim (the dev manifest already had one)shortcuts, pcsx2-dev.json is renamed to match how other dev builds are named (see dolphin-dev for example).persist, dropped deprecated items and addedcache,patches&videos(with pcsx2.json also getting:covers&gamesettingsto bring it in line with the dev manifest)checkveron pcsx2-dev.json uses thegithubkey instead ofurl.autoupdateon pcsx2.json drops the extract_dir as that isn't needed.The goal was to harmonise the two as much as possible.