Skip to content

Unnecessary object creation and casting in loop - MAPExtensionContainerImpl is created and immediately cast #355

Description

@sgurivir

RepoIQ (http://repoiq.ai) analysis has identified a potential optimization in
in _decode in map/map-impl/src/main/java/org/restcomm/protocols/ss7/map/primitives/ExternalSignalInfoImpl.java

Unnecessary object creation and casting in loop - MAPExtensionContainerImpl is created and immediately cast

Impact: Minor performance overhead from unnecessary casting operation in parsing loop

Potential Solution: Declare variable as MAPExtensionContainerImpl type directly: MAPExtensionContainerImpl extensionContainerImpl = new MAPExtensionContainerImpl(); extensionContainerImpl.decodeAll(ais); this.extensionContainer = extensionContainerImpl;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions