Tighten comments in unexpected-keyword-argument error path

Author: jhonabreul

src/runtime/MethodBinder.cs

@@ -1016,9 +1016,7 @@ internal virtual NewReference Invoke(BorrowedReference inst, BorrowedReference a
                 // If we already have an exception pending, don't create a new one
                 if (!Exceptions.ErrorOccurred())
                 {
-                    // A keyword argument whose name no candidate overload accepts gets the
-                    // Python-native "unexpected keyword argument" error: the generic no-match
-                    // message below does not echo kwargs, leaving the actual mistake invisible.
+                    // Unknown kwarg names get the Python-style error; the generic message below does not echo kwargs.
                     if (TryRaiseUnexpectedKeywordArgumentError(kw, info, methodinfo))
                     {
                         return default;
@@ -1132,11 +1130,8 @@ internal virtual NewReference Invoke(BorrowedReference inst, BorrowedReference a
         }
 
         /// <summary>
-        /// When a bind failure involves a keyword argument whose name no candidate overload
-        /// accepts, raises the Python-style "got an unexpected keyword argument" TypeError
-        /// (with a "Did you mean" hint when a similarly-named parameter exists) and returns
-        /// true. Returns false when every kwarg name is accepted by at least one overload,
-        /// so the generic no-match error is raised instead.
+        /// Raises "got an unexpected keyword argument" and returns true when a kwarg name is
+        /// accepted by no candidate overload; returns false to let the generic no-match error be raised.
         /// </summary>
         private bool TryRaiseUnexpectedKeywordArgumentError(BorrowedReference kw, MethodBase info, MethodInfo[] methodinfo)
         {
@@ -1146,9 +1141,7 @@ private bool TryRaiseUnexpectedKeywordArgumentError(BorrowedReference kw, Method
                 return false;
             }
 
-            // The same candidate set Bind considered: parameter names are snake_case for
-            // snake_case-registered methods and original for the original ones, matching
-            // the names the caller can actually use.
+            // Same candidate set Bind considered; ParameterNames are already in the caller's convention.
             var methods = info == null
                 ? GetMethods()
                 : new List<MethodInformation>(1) { new MethodInformation(info, true) };
@@ -1206,10 +1199,8 @@ private bool TryRaiseUnexpectedKeywordArgumentError(BorrowedReference kw, Method
         }
 
         /// <summary>
-        /// The candidate parameter name closest to the unexpected kwarg name, or null when
-        /// none is similar enough to suggest. A candidate is considered when it is within
-        /// a small edit distance of the name, or when one contains the other (e.g. 'as_tag'
-        /// suggests 'tag'); containment requires 3+ characters so tiny names don't match.
+        /// Closest parameter name to suggest, or null: small edit distance, or containment
+        /// between names of 3+ characters (e.g. 'as_tag' suggests 'tag').
         /// </summary>
         private static string ClosestParameterName(string name, HashSet<string> parameterNames)
         {
@@ -1234,7 +1225,7 @@ private static string ClosestParameterName(string name, HashSet<string> paramete
             return best;
         }
 
-        // Case-insensitive Levenshtein distance, local to keyword suggestions.
+        // Case-insensitive Levenshtein distance.
         private static int KeywordEditDistance(string a, string b)
         {
             a = a.ToLowerInvariant();

tests/test_method.py

@@ -1105,16 +1105,13 @@ def test_default_params():
         MethodTest.DefaultParams(1,2,3,4,5)
 
 def test_unexpected_keyword_argument_with_suggestion():
-    # A kwarg no overload accepts raises the Python-style error naming the kwarg,
-    # with a did-you-mean hint when a similarly-named parameter exists.
     with pytest.raises(TypeError) as excinfo:
         MethodTest.order_like_method("SPY", 10, as_tag="EmergencyFlatten")
     message = str(excinfo.value)
     assert "order_like_method() got an unexpected keyword argument 'as_tag'" in message
     assert "Did you mean 'tag'?" in message
 
-    # Same behavior when calling through the original PascalCase name; parameter
-    # names are the original ones there.
+    # PascalCase call path: parameter names are the original ones.
     with pytest.raises(TypeError) as excinfo:
         MethodTest.OrderLikeMethod("SPY", 10, asTag="EmergencyFlatten")
     message = str(excinfo.value)
@@ -1123,7 +1120,6 @@ def test_unexpected_keyword_argument_with_suggestion():
 
 
 def test_unexpected_keyword_argument_without_suggestion():
-    # No parameter is remotely similar: the kwarg is still named, but no hint is added.
     with pytest.raises(TypeError) as excinfo:
         MethodTest.order_like_method("SPY", 10, completely_unrelated_name=1)
     message = str(excinfo.value)
@@ -1144,9 +1140,7 @@ def test_valid_keyword_arguments_still_bind():
 
 
 def test_valid_keyword_argument_names_keep_no_match_message():
-    # All kwarg names are real parameters, but the call still cannot bind ('d' is
-    # supplied both positionally and by name): the classic no-method-matches
-    # message must be preserved for this case.
+    # 'd' is supplied both positionally and by name: valid names, unbindable call.
     with pytest.raises(TypeError) as excinfo:
         MethodTest.DefaultParams(1, 2, 3, 4, d=5)
     assert "No method matches given arguments for default_params" in str(excinfo.value)