Skip to content

Head pending notes ## Unreleased and drop the dash from CHANGELOG.md release headers - #55

Open
1-Bort-1 wants to merge 3 commits into
mainfrom
agent/54-bring-atmosphericmodels-changelog-to-the
Open

1-Bort-1 wants to merge 3 commits into
mainfrom
agent/54-bring-atmosphericmodels-changelog-to-the

Conversation

@1-Bort-1

@1-Bort-1 1-Bort-1 commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

We want one changelog format across the OpenSourceAWE packages, so this gives AtmosphericModels the same headers as the others. Notes not yet released now sit under a plain ## Unreleased header, not under a version marked "(unreleased)". Every release is headed ## AtmosphericModels vX.Y.Z YYYY-MM-DD, with no dash between the version and the date. Only header lines change. Every note reads as before, and the citation file is untouched.

The release script in this repo is unchanged. The next version bump replaces it with the shared copy, which reads this format.

Verification

  • Reproduced first: n/a — headers only
  • Shared release script, --dry-run on a simulated bump of this head (## Unreleased → ## AtmosphericModels v0.3.13 2026-10-10, version 0.3.13): reads v0.3.13 and the ### Added notes, exit 0 (GitHub calls stubbed)
  • Every ## header in CHANGELOG.md is ## Unreleased or ## AtmosphericModels vX.Y.Z YYYY-MM-DD
  • Local full suite: PASS (earlier round; markdown only since) · GitHub CI: not yet read
  • REUSE lint: not run (reuse not installed on the box)
  • Risk: running the old in-repo release script before the bump lands shows the already-registered v0.3.12, which the registrator refuses.

Opened by 1-Bort-1, an AI agent working for @1-Bart-1.
Closes #54 · task AtmosphericModels.jl-54

Pending notes sit under '## Unreleased'; released sections are headed
'## AtmosphericModels vX.Y.Z YYYY-MM-DD' without the dash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@1-Bort-1 1-Bort-1 added agent:running Agent task state agent:ci Agent task state and removed agent:running Agent task state labels Oct 6, 2026

@1-Bort-1 1-Bort-1 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (advisory)

Verdict: APPROVE · 0 inline, 0 off the diff

Good

  • The diff matches the PR card: 6 header lines change in CHANGELOG.md, and the note text, the ### groups and all other files are untouched (read in the diff).
  • Every ## line in CHANGELOG.md is now ## Unreleased or ## AtmosphericModels vX.Y.Z YYYY-MM-DD; a grep of the ## lines on this branch shows no exceptions.
  • v0.3.8–v0.3.12 now use the same header form as v0.3.0–v0.3.7, which were already in the convention, so the whole file is consistent.
  • The in-repo bin/release still works on this file: its awk matches ^## AtmosphericModels and reads the version from $3, both unaffected by dropping the -, and it skips ## Unreleased (read bin/release:53-70).
  • Only headers changed, so the version, manifests and REUSE headers are untouched and no tests or docs are affected.

Not good

  • Until the bump PR lands, the in-repo bin/release on main passes over ## Unreleased and picks v0.3.12, which already matches Project.toml. A manual run would post the 0.3.12 notes again instead of failing. The old v0.3.13 (unreleased) header failed the version check and blocked this, so the safety net is gone until the bump replaces the script.
  • CLAUDE.md says bin/release "extracts the top section of CHANGELOG.md". With ## Unreleased on top, that section is no longer what it extracts. The doc is slightly stale, though CLAUDE.md is reasonably left out of a headers-only PR.
  • The card's second verification line quotes the box's error with a double space (CHANGELOG top is (expected v0.3.12)). That is the tool's real output, but it reads like a typo to someone who hasn't seen the tool.

claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.

@1-Bort-1 1-Bort-1 added agent:queued Agent task state and removed agent:ci Agent task state labels Oct 6, 2026
@1-Bort-1

1-Bort-1 commented Oct 6, 2026 •

Copy link
Copy Markdown
Member Author

Local full suite: PASS (1 min, Julia 1.13.0, one cell of the matrix)

@1-Bort-1 1-Bort-1 added agent:running Agent task state and removed agent:queued Agent task state labels Oct 6, 2026
@1-Bort-1

1-Bort-1 commented Oct 6, 2026

Copy link
Copy Markdown
Member Author
  1. True, and I added it to the card's Risk line. There's no change to bin/release: before the bump lands, a run shows v0.3.12 and asks [y/N], JuliaRegistrator refuses a version that's already registered, and the bump replaces the script with the box's copy. 2) I left CLAUDE.md out of this headers-only PR. Its bin/release line should follow the script the bump puts in place. 3) Fixed: the card now describes the error instead of quoting the tool's double-spaced output.

@1-Bort-1 1-Bort-1 added agent:ci Agent task state and removed agent:running Agent task state labels Oct 6, 2026
@1-Bort-1
1-Bort-1 marked this pull request as ready for review October 6, 2026 12:16
@1-Bort-1 1-Bort-1 added agent:review Agent task state and removed agent:ci Agent task state labels Oct 6, 2026
@1-Bort-1
1-Bort-1 requested a review from 1-Bart-1 October 6, 2026 12:17
@1-Bort-1

1-Bort-1 commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

From Agents-635 (1-Bart-1/Agents#635)

Per 1-Bart-1/Agents#635: since 1-Bart-1/Agents#634 the release bump writes headers as ## <Package> vX.Y.Z DD-MM-YYYY. Please switch every release header this branch writes from ISO YYYY-MM-DD to DD-MM-YYYY (e.g. 2026-09-28 → 28-09-2026), and rewrite the title and description to match. Keep date-released in CITATION.cff ISO, as the CFF schema requires.

@1-Bort-1 1-Bort-1 added agent:queued Agent task state agent:running Agent task state and removed agent:review Agent task state agent:queued Agent task state labels Oct 9, 2026
Every '## AtmosphericModels vX.Y.Z' header now carries its date as
DD-MM-YYYY, the form the release bump writes since 1-Bart-1/Agents#634.
CITATION.cff keeps its ISO date-released.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@1-Bort-1 1-Bort-1 changed the title Head pending notes ## Unreleased and drop the dash from release headers in CHANGELOG.md Head pending notes ## Unreleased and date release headers DD-MM-YYYY in CHANGELOG.md Oct 9, 2026
@1-Bort-1 1-Bort-1 added agent:ci Agent task state agent:review Agent task state and removed agent:running Agent task state agent:ci Agent task state labels Oct 9, 2026
@1-Bort-1

Copy link
Copy Markdown
Member Author

From Agents-635 (1-Bart-1/Agents#635)

Per 1-Bart-1/Agents#635 (comment 6099024080) ISO is the convention after all: the bump goes back to writing ## <Package> vX.Y.Z YYYY-MM-DD. Please put every release header this branch writes back to ISO YYYY-MM-DD (e.g. 28-09-2026 → 2026-09-28), including any already in the base it carries, and rewrite the title and description to match. date-released in CITATION.cff stays ISO. Sorry for the round trip.

@1-Bort-1 1-Bort-1 added agent:queued Agent task state agent:running Agent task state and removed agent:review Agent task state agent:queued Agent task state labels Oct 10, 2026
Undoes 5311e03: the release bump writes ## <Package> vX.Y.Z YYYY-MM-DD
(1-Bart-1/Agents#635), so every release header goes back to ISO.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@1-Bort-1 1-Bort-1 changed the title Head pending notes ## Unreleased and date release headers DD-MM-YYYY in CHANGELOG.md Head pending notes ## Unreleased and drop the dash from CHANGELOG.md release headers Oct 10, 2026
@1-Bort-1

Copy link
Copy Markdown
Member Author

Fixed in 3fc1493: every release header is ISO YYYY-MM-DD again; CITATION.cff untouched.

@1-Bort-1 1-Bort-1 added agent:ci Agent task state agent:review Agent task state and removed agent:running Agent task state agent:ci Agent task state labels Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:review Agent task state

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring AtmosphericModels' changelog to the release convention

1 participant