Skip to content

dcgmi InstallCtrlHandler unhandled return #294

Description

@nfisher

Description

In dcgmi the InstallCtrlHandler silently ignores the return codes in

InstallCtrlHandler();
.

Expected Behaviour

The return value of InstallCtrlHandler should be validated. If the installation fails, the code should:

  • Log an error with sufficient context.
  • Avoid continuing execution in an invalid state.

Actual Behavior

The function is invoked without checking its return value, so failures are ignored.

Why This Matters

Failing to install a control handler can prevent proper signal handling (e.g., shutdown, interrupts). Ignoring the result:

  • Obscures root causes during failures.
  • May lead to resource leaks or improper shutdown.
  • Violates standard error-handling practices.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions